Skip to content

gate tests on features they use #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
folkertdev merged 2 commits into from
Feb 22, 2026
Merged

gate tests on features they use #475

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
053cb66
gate tests on features they use
alexanderkjall Feb 22, 2026
df3c64d
review feedback
alexanderkjall Feb 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion zlib-rs/src/adler32/neon.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ unsafe fn accum32(s: (u32, u32), buf: &[uint8x16_t]) -> (u32, u32) {
(vget_lane_u32(as_, 0), vget_lane_u32(as_, 1))
}

#[cfg(test)]
#[cfg(all(test, feature = "std", target_feature = "neon"))]
Copy link
Copy Markdown
Member

@folkertdev folkertdev Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change this to

Suggested change
#[cfg(all(test, feature = "std", target_feature = "neon"))]
#[cfg(all(test, feature = "std", any(miri, target_feature = "neon")))]

That way Miri can still find places where we assume a target feature but don't declare it.

Copy link
Copy Markdown
Contributor Author

@alexanderkjall alexanderkjall Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for taking up your time, this is the same as #416 i think

Copy link
Copy Markdown
Member

@folkertdev folkertdev Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one is for neon, that one for avx? This looks fine to me with the miri change, because neon is enabled by default on the linux and macos runners. The same is not true for x86, which makes it trickier.

Copy link
Copy Markdown
Contributor Author

@alexanderkjall alexanderkjall Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it was me that misunderstood, I'll reopen with the suggested improvement.

mod tests {
use super::*;

Expand Down