Skip to content

fix: Display issue on transaction form and home filter - #216

Merged
austin047 merged 2 commits into
devfrom
fix/test_bugs
Aug 7, 2026
Merged

fix: Display issue on transaction form and home filter#216
austin047 merged 2 commits into
devfrom
fix/test_bugs

Conversation

@Wuyika

@Wuyika Wuyika commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Description

  • Fixed display issue on transaction form
  • Fixed home filter for transfers
Dark Theme Light Theme
Light Theme Screenshot Dark Theme Screenshot

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@sourceant

sourceant Bot commented Aug 7, 2026

Copy link
Copy Markdown

Code Review Summary

This pull request improves the theme consistency of the transaction forms and fixes a filtering issue for transfers on the Home screen. The UI changes correctly utilize project design tokens for colors and spacing. However, a generated Gradle build report was accidentally included in the commit.

🚀 Key Improvements

  • Standardized UI components using design_tokens (tones and AppRadii), ensuring better dark mode support and consistency across forms.
  • Fixed the transaction filter logic in HomeScreen to correctly handle 'global' transfers (transfers without an explicit group), ensuring they are visible across group views.
  • Improved visual feedback for input fields and checkboxes using appropriate theme colors.

💡 Minor Suggestions

  • Review the consistency of corner radii in CustomAutoCompleteSearch vs the global theme updates.

🚨 Critical Issues

  • A generated build report (android/build/reports/problems/problems-report.html) was included in the source control, which should be avoided.

@sourceant sourceant Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete. No specific code suggestions were generated. See the overview comment for a summary.

@austin047
austin047 merged commit d8d1ba7 into dev Aug 7, 2026
3 checks passed
@austin047
austin047 deleted the fix/test_bugs branch August 7, 2026 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants