perf: use blazediff for faster screenshots comparison#1983
Conversation
|
Hi @teimurjan , Thank you so much for taking the time to create this PR and for your work on blazediff. The package looks really well-crafted and the presentation is excellent. I genuinely appreciate the effort that's gone into it. However, at this stage we're exercising extra caution around dependency changes, particularly given the recent NPM supply chain security incidents. Our current policy is to conduct more thorough reviews before switching out established dependencies, even for what appear to be compelling alternatives. I'd like to keep this PR open and revisit it in a few months once things have settled down a bit and we've had a chance to do proper due diligence. I hope you understand; it's nothing personal, just us being extra careful in the current climate. One other quick note: there appears to be a build error in the current changes related to outdated Node typings or a version mismatch. If you do want to update the PR in the meantime, that would need addressing. Thanks again for your contribution and for understanding our position on this. |
|
Hey @SlicedSilver! I understand that, no worries. I'll fix the build issue and keep the PR open. Thanks! |
|
Hey @SlicedSilver! The issue is fixed. By the way, the package was also integrated into Shopify's repo recently: Shopify/react-native-skia@3e141ef. 🙂 |
|
Hey @SlicedSilver! Did you have a chance to make a more thorough review of BlazeDiff? |
teimurjan
force-pushed
the
perf/use-blazediff-instead-of-pixelmatch
branch
from
947bd5a to
bcab858
Compare
2 participants
perf
PR checklist:
Overview of change:
This PR replaces pixelmatch with blazediff in the E2E testing infrastructure to improve image comparison performance.
BlazeDiff is ~1.5x times faster than pixelmatch, producing the same results in type-safe code that is available in ESM and CJS.
BlazeDiff is already integrated in:
Is there anything you'd like reviewers to focus on?