-
Notifications
You must be signed in to change notification settings - Fork 46
feat: config を薄くして外部から差し込みやすくする #5005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
uni-kakurenbo
wants to merge
2
commits into
master
Choose a base branch
from
feat/remove-config-js
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| name: Check Config Schema | ||
|
|
||
| on: | ||
| pull_request: | ||
|
|
||
| jobs: | ||
| check-schema: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v6 | ||
|
|
||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v6 | ||
| with: | ||
| node-version: '20' | ||
|
|
||
| - name: Install dependencies | ||
| run: npm ci | ||
|
|
||
| - name: Generate JSON Schema from config.d.ts | ||
| run: npm run generate-schema | ||
|
|
||
| - name: Check for changes | ||
| run: | | ||
| git diff --exit-code config.schema.json |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| {"$schema":"http://json-schema.org/draft-07/schema#","type":"object","properties":{"name":{"type":"string","description":"アプリ名 省略時、空文字列時は`'traQ'`"},"firebase":{"type":"object","properties":{"apiKey":{"type":"string"},"appId":{"type":"string"},"projectId":{"type":"string"},"messagingSenderId":{"type":"string"},"vapidKey":{"type":"string","description":"https://firebase.google.com/docs/cloud-messaging/js/client#configure_web_credentials_with_fcm"}},"required":["apiKey","appId","projectId","messagingSenderId","vapidKey"],"additionalProperties":false,"description":"Firebase用設定 省略時は通知機能を無効化 https://firebase.google.com/docs/web/learn-more#config-object"},"enableQall":{"type":"boolean","description":"Qall機能を有効化するかどうか 省略時は無効化"},"enableSearch":{"type":"boolean","description":"検索機能を有効化するかどうか 省略時は無効化"},"services":{"type":"array","items":{"type":"object","properties":{"label":{"type":"string","description":"表示名"},"iconPath":{"type":"string","description":"`/img/services`からのアイコンへのパス(拡張子含む)"},"appLink":{"type":"string","description":"リンク先"}},"required":["label","iconPath","appLink"],"additionalProperties":false},"description":"アプリ一覧に表示されるサービス 省略時はアプリ一覧ボタンを非表示にする"},"ogpIgnoreHostNames":{"type":"array","items":{"type":"string"},"description":"OGPが表示されないようにするホスト 省略時は、すべてのホストのOGPを表示する"},"wikiPageOrigin":{"type":"string","description":"Wikiのユーザーページへのリンク undefinedにするとリンクが表示されない"},"blogPagePrefix":{"type":"string","description":"ブログの投稿者ページへのリンク undefinedにするとリンクが表示されない"},"auth":{"type":"object","properties":{"resetLink":{"type":"string","description":"ログイン画面での「パスワードを忘れた」のリンクのリンク先"},"changeLink":{"type":"string","description":"設定画面での「パスワードは~から可能です」のリンクのリンク先"},"changeName":{"type":"string","description":"設定画面での「パスワードは~から可能です」の「~」の表示"}},"required":["resetLink","changeLink","changeName"],"additionalProperties":false,"description":"外部認証が有効の場合の設定 省略時は各種リンクが表示されない"},"isRootChannelSelectableAsParentChannel":{"type":"boolean","description":"チャンネル変更権限をもっていないユーザーでも チャンネル作成時に親チャンネルとしてrootを選択可能にする サーバーでははじいていないので、APIをたたけば誰でも可能"},"tooLargeFileMessage":{"type":"string","description":"大きなファイルサイズのファイルを送信した際に表示される補足メッセージ `%s`の部分には「画像」または「ファイル」が入る","default":"大きい%sの共有には別のサービスを利用してください。"},"showWidgetCopyButton":{"type":"boolean","description":"iframe埋め込みウィジェットのコピーボタンの有効化 同じドメインの/widget/以下にtraQ-Widgetがデプロイされていることが前提 省略時は`false`"},"inlineReplyDisableChannels":{"type":"array","items":{"type":"string"},"description":"通知でのインライン返信を無効化するチャンネル 省略時はどのチャンネルも無効化しない","examples":[["#general","#random"]]},"iosPwaInfoLink":{"type":"string","description":"iOSアプリの廃止告知バナーに載せるPWAについてのリンク 省略時はリンクへの誘導テキストが載らない"},"defaultChannelId":{"anyOf":[{"type":"string"},{"type":"array","items":{"type":"string"}}],"description":"デフォルトチャンネルのチャンネル ID 起動時チャンネルが 設定されていない / 見つからない / 解決できない 場合に使用される 配列を与えた場合は先頭から優先して考慮され,最初に見つかったチャンネルが使用される 省略時は fallbackChannelPath にフォールバックする"},"fallbackChannelPath":{"type":"string","description":"どうしてもパスを解決できなかった場合など,最後に使用されるフォールバック (ID ではなくパス) `defaultChannelId` が設定されている場合はそちらが優先される 省略時は空文字列(チャンネルが選択されていない状態)","examples":["general"]},"$schema":{"type":"string"}},"required":["isRootChannelSelectableAsParentChannel"],"additionalProperties":false,"definitions":{}} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
なんか format がかかっちゃってる?理由がなければ戻してほしいかも