Repository navigation
Preserve bulk create field iterators - #2330
Open
IlyaKhalafi wants to merge 2 commits into
Open
IlyaKhalafi wants to merge 2 commits into
IlyaKhalafi wants to merge 2 commits into
Conversation
Merging this PR will not alter performance1 warning
Comparing |
IlyaKhalafi
force-pushed
the
fix/bulk-create-field-iterators
branch
from
October 23, 2026 16:36
5c13d23 to
72c7a54
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes generator-based
bulk_createfield options failing during SQL construction or after.sql(). With this, field names are captured once before validation and reused for previews and execution.Empty iterators follow the same validation as empty lists.
Motivation and Context
Fixes #2329.
How Has This Been Tested?
make checkand 43 focused tests passed. The full SQLite suite passed with 1,986 tests, 149 skips and two expected failures. PostgreSQL and MySQL SQL generation was checked without live databases.Checklist