[nextage_ik_plugin] In harmonize function: Limit angles to [-2*PI; 2*PI]#342
Open
ghost wants to merge 1 commit intotork-a:indigo-develfrom
Open
[nextage_ik_plugin] In harmonize function: Limit angles to [-2*PI; 2*PI]#342ghost wants to merge 1 commit intotork-a:indigo-develfrom
ghost wants to merge 1 commit intotork-a:indigo-develfrom
Conversation
Member
|
Contributor
|
I'm not keen on ikfast so no need to point to me. Plenty others are. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I am reporting a minor bug about the harmonize function inside the two next files (line 482, indigo-devel branch):
rtmros_nextage/nextage_ik_plugin/src/nextage_left_arm_ikfast_moveit_plugin.cpp
rtmros_nextage/nextage_ik_plugin/src/nextage_right_arm_ikfast_moveit_plugin.cpp
A minus sign was missing in order to properly limit the angles in [-2PI; 2PI]
It is fixed with this pull request. It was tested with the simulator.
Regards,
Yoann.