Skip to content

ENH accelarate dicodile#59

Open
hndgzkn wants to merge 28 commits into
tomMoral:mainfrom
hndgzkn:ENH_accelarate_dicodile
Open

ENH accelarate dicodile#59
hndgzkn wants to merge 28 commits into
tomMoral:mainfrom
hndgzkn:ENH_accelarate_dicodile

Conversation

@hndgzkn
Copy link
Copy Markdown
Collaborator

@hndgzkn hndgzkn commented Jan 3, 2023

Improves dicodile's performance:

  • Update signatures of functions adding seg_bounds and seg_inner_bounds to avoid unnecessary calls to Segmentation.get_seg_bounds.
  • Separates worker and local segmentation classes.

@hndgzkn hndgzkn changed the title Enh accelarate dicodile ENH accelarate dicodile Jan 3, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 3, 2023

Codecov Report

Base: 78.29% // Head: 78.60% // Increases project coverage by +0.30% 🎉

Coverage data is based on head (24d414b) compared to base (8e5a75a).
Patch coverage: 95.16% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
+ Coverage   78.29%   78.60%   +0.30%     
==========================================
  Files          43       43              
  Lines        2856     2888      +32     
==========================================
+ Hits         2236     2270      +34     
+ Misses        620      618       -2     
Flag Coverage Δ
unittests 78.60% <95.16%> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dicodile/update_z/coordinate_descent.py 41.62% <80.00%> (+0.44%) ⬆️
dicodile/workers/dicod_worker.py 96.03% <89.36%> (+0.04%) ⬆️
dicodile/utils/segmentation.py 96.69% <95.80%> (+0.18%) ⬆️
dicodile/update_z/dicod.py 79.25% <100.00%> (+0.22%) ⬆️
dicodile/utils/debugs.py 100.00% <100.00%> (ø)
dicodile/utils/tests/test_segmentation.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hndgzkn hndgzkn force-pushed the ENH_accelarate_dicodile branch from 7c12a21 to 24d414b Compare January 6, 2023 13:33
@hndgzkn hndgzkn marked this pull request as ready for review January 10, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant