[TCL-6909] feat(slurm): add Model-Aware TorchPass chart support#35
Closed
sagrawal-byte wants to merge 1 commit into
Closed
[TCL-6909] feat(slurm): add Model-Aware TorchPass chart support#35sagrawal-byte wants to merge 1 commit into
sagrawal-byte wants to merge 1 commit into
Conversation
Two additions, both gated/opt-in so default renders are unchanged: - login: support `login.initContainers` (the login Deployment template had no passthrough). Needed so the torchpass-payload initContainer can populate /opt/torchpass on login pods, matching the worker nodeset. - torchpass: new `torchpass.enabled` block rendering the cluster-scoped pieces the chart owns -- the torchpass-login-profile ConfigMap (sourced by login + worker shells) and the torchpass-orchestrator Service (:26001, selecting the slurmctld pod). The clockworks sidecar + payload initContainers + volumes are injected by the caller via the controller/nodeset/login podSpec values. Verified with `helm lint` + `helm template`. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
sagrawal-byte
changed the title
Author
|
Superseded — combined with #36 into a single PR from the merged branch (sagrawal/torchpass-chart-pkg), which is also the exact source tcloud-charts#354's tgz was packaged from. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Gated, opt-in chart support for the Model-Aware TorchPass ("clockworks") add-on. Default renders unchanged (
torchpass.enabled: false,login.initContainers: []).login.initContainers— login Deployment had no initContainers passthrough (unlike controller/nodeset). Added so thetorchpass-payloadinitContainer can populate/opt/torchpasson login pods, matching the worker nodeset.torchpass.enabledblock — renders the cluster-scoped pieces the chart owns: thetorchpass-login-profileConfigMap (/etc/profile.d/torchpass.sh, sourced by login + worker shells) and thetorchpass-orchestratorService (:26001, selecting the slurmctld pod).The clockworks sidecar (controller),
torchpass-payloadinitContainers (nodeset + login) and volumes/mounts are injected by the caller via existingcontroller.podSpec/nodesets.<name>.podSpec/login.{initContainers,extraVolumes,extraVolumeMounts}values. Companion: together-cloud-cluster-operator PR #658.Test plan
helm lint .→ 0 failures.helm templatewithtorchpass.enabled=true+ alogin.initContainersentry renders the ConfigMap, orchestrator Service, and login initContainer; default values render unchanged.Follow-up (packaging — not in this PR)
Chart source is vendored into tcloud-charts as
substrate/slurm-*.tgz. To ship: bump chart version,helm package, update tcloud-chartsindex.yaml, bump the operator's pinned chartVersion.InstallOncereconcile = only new clusters adopt it. (A local tcloud-charts checkout had in-flight WIP copying this chart + aslurm-operator-tmp— check for overlap before packaging.)🤖 Generated with Claude Code