Repository navigation
fix: land endpoint validation and review follow-ups on main - #224
Merged
Merged
Conversation
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 43 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The endpoint-validation refactor and review cleanup from #221 and #222 landed on
stack/pr-220, leaving them absent frommain. Apply the combined changes to currentmainand resolve the integration conflicts.The integration preserves the fixes already on
main: exact-width ASCII date/time validation, input-preserving model parsing, conditional ETag safeguards, iRail service branding, theIRailwheel import, and the latest ty dependency. Remove the duplicated ETag regression test created by combining the branches.Validation: 131 offline tests pass on Python 3.12 and 3.14 with 100% measured coverage. Ruff, formatting, ty, and diff checks pass. The sdist and wheel build; the wheel installs in a fresh Python 3.12 environment and passes isolated imports, package exports, and
py.typedchecks. Live API tests were not run.