Skip to content

fix: land endpoint validation and review follow-ups on main - #224

Merged
tjorim merged 1 commit into
mainfrom
fix/land-review-follow-ups
Oct 21, 2026
Merged

tjorim merged 1 commit into
mainfrom
fix/land-review-follow-ups

Conversation

@tjorim

@tjorim tjorim commented Oct 21, 2026

Copy link
Copy Markdown
Owner

The endpoint-validation refactor and review cleanup from #221 and #222 landed on stack/pr-220, leaving them absent from main. Apply the combined changes to current main and resolve the integration conflicts.

  • Move required-argument and station exclusivity checks into endpoint methods, retain shared value validation, and remove the duplicated endpoint-rule table.
  • Preserve HTTP status 200 when successful responses fail model deserialization.
  • Adopt pytest-cov for the existing 92% combined statement/branch coverage gate and restore useful explanatory comments.

The integration preserves the fixes already on main: exact-width ASCII date/time validation, input-preserving model parsing, conditional ETag safeguards, iRail service branding, the IRail wheel import, and the latest ty dependency. Remove the duplicated ETag regression test created by combining the branches.

Validation: 131 offline tests pass on Python 3.12 and 3.14 with 100% measured coverage. Ruff, formatting, ty, and diff checks pass. The sdist and wheel build; the wheel installs in a fresh Python 3.12 environment and passes isolated imports, package exports, and py.typed checks. Live API tests were not run.

@coderabbitai

coderabbitai Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 43 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 62d3db8d-bdf6-458e-adfe-266c1111bcea
📥 Commits

Reviewing files that changed from the base of the PR and between 4d8a69c and 1e6283a.

⛔ Files ignored due to path filters: 1
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing: 8
  • .github/workflows/publish.yml
  • .github/workflows/test.yml
  • README.md
  • pyproject.toml
  • pyrail/irail.py
  • pyrail/models.py
  • tests/live/live_api.py
  • tests/test_irail.py
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tjorim
tjorim merged commit 3eb73da into main Oct 21, 2026
9 checks passed
@tjorim
tjorim deleted the fix/land-review-follow-ups branch October 21, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant