feat(graph): rank impact radius by weighted paths#646
Merged
Conversation
code-review-graph reviewOverall risk: 0.55 (MEDIUM) — 23 changed function(s)/class(es), 0 affected flow(s), 13 test gap(s) Risk-scored changes
Test gaps
Token savings: this graph-backed report used ~44,017 fewer tokens (~91%) than reading every changed file in full (estimated, chars/4 approximation). Powered by code-review-graph — local-first analysis; no code leaves the CI runner. |
tirth8205
force-pushed
the
codex/port-weighted-impact
branch
3 times, most recently
from
July 17, 2026 16:55
a33f62d to
1cd76a6
Compare
Co-authored-by: Stefan Hudici <shudici@gmail.com>
tirth8205
force-pushed
the
codex/port-weighted-impact
branch
from
July 17, 2026 16:59
1cd76a6 to
4284f05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n\nThis is the safe replacement for #606 and retains Stefan Hudici as co-author.\n\n- rank impacted nodes by their strongest weighted path;\n- expose impact_score on public impacted-node results;\n- keep SQLite and NetworkX ordering/scores aligned, including parallel edge kinds;\n- retain unresolved endpoints as traversal bridges without letting them consume result slots;\n- make truncation exact with a one-row sentinel and an exact total count;\n- validate decay/floor environment values as finite values inside the supported range;\n- replace recursive path enumeration with bounded best-score relaxation, one row per endpoint, so dense cyclic graphs cannot explode exponentially.\n\n## Verification\n\n- 12 focused SQL/NetworkX/public-tool tests passed;\n- 1,540 non-daemon tests passed locally, with 2 existing xpasses;\n- Ruff and git diff checks passed;\n- dedicated regressions cover best-path ranking, deep-strong versus shallow-weak paths, score-floor termination, unknown edge weights, parallel edges, ghost bridges, exact boundary truncation, invalid environment values, and a dense 12-node cycle at depth 25.\n\nThe macOS daemon test file is left to required CI because the third-party FSEvents thread segfaults in the local macOS runner; the GitHub Windows and Linux jobs remain the merge gates.