fix: expand trailing slash ignore patterns#583
Merged
tirth8205 merged 2 commits intoJul 17, 2026
Conversation
|
Nice fix! Treating trailing-slash patterns as recursive globs matches .gitignore semantics. The leading slash strip is a good touch too. Test with |
Bakul2006
pushed a commit
to Bakul2006/code-review-graph
that referenced
this pull request
Jul 17, 2026
Port the final reviewed safe-anywhere versus root-relative behavior from PR tirth8205#92 on top of PR tirth8205#583's trailing-slash support. Keep unanchored custom directory patterns gitignore-compatible while anchoring ambiguous defaults. Co-Authored-By: Chintan Gohil <echintangohil@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #579 by treating plain directory entries (for example
vendor/) in.code-review-graphignoreas recursive ignore rules.What's changed
_load_ignore_patterns:/for compatibility/to/**so directory-only entries are respectedvendor/andgenerated/intests/test_incremental.py.Validation
tests/test_incremental.py.