Jules/go refactor#18
Closed
jdrean wants to merge 4 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Rewrite modelwrap in Go with a deterministic packer/consumer, add encrypted EMWP artifacts, and ship a pinned
modelwrapCLI that launches the packer in a digest-pinned container. Adds a formal spec, CI/e2e, and a release that publishes both image and CLI.New Features
github.com/tinfoilsh/modelwrap:wrap(packer) andunwrap(consumer) with a shared protocol in the root package.modelwrapCLI launcher runs packing inside the pinned image; supports--model-dir,--encrypt,--key-file,--verify,--image, and--local. Secrets (HF_TOKEN,PRIVATE_MODEL_KEY_B64) are passed through without leaking values..emwpand.emwp.info; deterministic UUIDs. Offline verify for MWP/EMWP supported.pack.py; downloads viahffromhuggingface_hub. EROFS and dm-verity parameters are explicitly pinned for reproducibility.SPEC.md). CI runs fmt/vet/tests and e2e; release builds linux/amd64 image and a static CLI embedding the image digest and creates a GitHub release.Migration
modelwrap(notpython3 pack.py). Update run commands accordingly.--encryptand provide a 64-byte master key via--key-file,PRIVATE_MODEL_KEY_FILE, orPRIVATE_MODEL_KEY_B64; run with--privileged..mpkand.infoare unchanged (legacympkalias still accepted).--imageorMODELWRAP_IMAGE; use--localto bypass the container if needed.Written for commit ffc95fc. Summary will update on new commits.