Fix desktop chrome and bound model scans - #648
Draft
timtoole02 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The overlay title bar could leave the macOS desktop window difficult to drag. Native window chrome is simpler and more reliable.
Model metadata reads can block on slow, disconnected, or permission-gated removable storage. The bounded blocking task keeps the local-models API responsive and reports an actionable per-file admission reason instead of hanging the request.
User impact
Desktop users get reliable native window controls. Users who keep models on external drives receive the appropriate macOS permission prompt, and an unavailable drive can no longer indefinitely block model discovery.
This PR is based directly on
mainand has no dependency on PR #644.Validation
cargo fmt --all -- --checkcargo check --locked --bin camelidcargo test --locked -p camelid-desktop: 22 passednpm.cmd run buildgit diff --check