Skip to content

Track GlobalRef consistently#822

Merged
timholy merged 7 commits intotimholy:masterfrom
Keno:kf/globalref
Jul 24, 2024
Merged

Track GlobalRef consistently#822
timholy merged 7 commits intotimholy:masterfrom
Keno:kf/globalref

Conversation

@Keno
Copy link
Copy Markdown
Collaborator

@Keno Keno commented Jun 20, 2024

Companion PR to JuliaDebug/LoweredCodeUtils.jl#107. With both of these and JuliaDebug/JuliaInterpreter.jl#634, basic Revise functionality is working for me again on Julia master.

Keno and others added 2 commits June 20, 2024 05:54
Companion PR to JuliaDebug/LoweredCodeUtils.jl#107. With both of
these and JuliaDebug/JuliaInterpreter.jl#634, basic Revise functionality
is working for me again on Julia master.
@timholy
Copy link
Copy Markdown
Owner

timholy commented Jul 21, 2024

For me, here's the current status (with both JuliaInterpreter and LoweredCodeUtils devved on their current master branch):
nightly:
image

But more concerningly, on Julia 1.11:
image

JuliaInterpreter doesn't seem to be the culprit: on Revise's master branch, and with LoweredCodeUtils v2.4.8, I can dev the current master of JuliaInterpreter without breaking the tests. So this seems to be a feature of the changes to LoweredCodeUtils and Revise.

Is this working for you?

@timholy
Copy link
Copy Markdown
Owner

timholy commented Jul 21, 2024

OK, while there were many errors there didn't seem to be many causes.

@timholy timholy closed this Jul 21, 2024
@timholy timholy reopened this Jul 21, 2024
@timholy
Copy link
Copy Markdown
Owner

timholy commented Jul 23, 2024

Thanks Shuhei Keno!

@timholy timholy merged commit 4ad68c2 into timholy:master Jul 24, 2024
@timholy
Copy link
Copy Markdown
Owner

timholy commented Jul 24, 2024

Thanks again, @Keno!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants