-
Notifications
You must be signed in to change notification settings - Fork 764
gc: Implement GC state cache #10677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
MyonKeminta
wants to merge
18
commits into
tikv:master
Choose a base branch
from
MyonKeminta:m/gc-state-cache
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
gc: Implement GC state cache #10677
Changes from 7 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
29c5a64
implement server side
MyonKeminta c5ac0c0
update client
MyonKeminta c5e24d8
Add tests
MyonKeminta 490c66e
implement GC state cache
MyonKeminta d1ec3a6
Add leader check
MyonKeminta 1c03f0a
Add metrics
MyonKeminta f7eba22
gc,server: add GC state cache test coverage (#10617)
wfxr 48a19eb
Merge branch 'master' of https://github.com/tikv/pd into m/exclude-gc…
MyonKeminta dfdf3ba
Fix incorrect reusing of GetAllKeyspacesGCStates
MyonKeminta d8dd9fa
renaming
MyonKeminta 51af53b
update coments
MyonKeminta bcf3dc0
Merge branch 'm/exclude-gc-barriers' into m/gc-state-cache
MyonKeminta eb61606
Add bench to GetGCState
MyonKeminta ba4ddf3
fix check
MyonKeminta c01b556
Merge branch 'master' of https://github.com/tikv/pd into m/exclude-gc…
MyonKeminta 0ffb59b
fix lint
MyonKeminta a55889a
Merge branch 'm/exclude-gc-barriers' into m/gc-state-cache
MyonKeminta 54a66e6
fix check
MyonKeminta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make the new accessor API self-describing.
These exported accessors are now part of the public client contract, but they don't have GoDoc, and the error text still tells callers to pass nonexistent
exclude...parameters instead of usinggc.ExcludeGCBarriers(false)/gc.ExcludeGlobalGCBarriers(false). That leaves both generated docs and runtime guidance out of sync with the option-based API.As per coding guidelines, "Exported identifiers need GoDoc starting with the name; avoid stutter (
pd.PDServer->Server)."🤖 Prompt for AI Agents