Use ament_vendor for zmqpp library

[f0reachARR]

Description

Abstract

Use ament_vendor for zmqpp library, instead of ExternalProject.

Details

This section is same as autowarefoundation/zmqpp_vendor#9

References

• feat: use ament_vendor for setting up zmqpp autowarefoundation/zmqpp_vendor#9

Destructive Changes

• Install directory of zmqpp is changed

[github-actions]

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

• Is this pull request written in a way that is easy to read from a third-party perspective?
• Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
• If this pull request contains a destructive change, does this pull request contain the migration guide?
• Labels of this pull request are valid?
• All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
• The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

[github-actions]

Failure optional scenarios

Note

This is an experimental check and does not block merging the pull-request.
But, please be aware that this may indicate a regression.

scenario failed: execution_time_test

      <failure type="SimulationFailure" message="CustomCommandAction typed &quot;exitFailure&quot; was triggered by the named Conditions {&quot;update time checker&quot;, &quot;avoid startup&quot;}: {&quot;update time checker&quot;: Is the /simulation/interpreter/execution_time/update (= 0.005232999999999999804489725364) is greaterThan 0.005?}, {&quot;avoid startup&quot;: Is the simulation time (= 5.499999999999988453680543898372) is greaterThan 1.000000000000000000000000000000?}" />

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[HansRobo]

LGTM. I also checked the build include this on Autoware Evaluator.

[xmfcx]

@f0reachARR @HansRobo

Use ament_vendor for zmqpp library, instead of ExternalProject.

Could you explain why you've added ament_cmake_vendor_package dependency with this PR?

ament_cmake_vendor_package depends on the deprecated vcstool and Prevents us from going ahead with 📣 Switching from vcstool to vcs2l #6645.

I'm going to create a PR to switch to ExternalProject and remove the ament_cmake_vendor_package dependency.

This way the users can keep using the modern tooling.

Related:

• Migrate package dependency from vcstool to vcs2l. ament/ament_cmake#601

[xmfcx]

Actually, since this PR comes with a destructive change, I don't have the courage to revert this.

We should instead update the build farm version with these changes and use this vendor package from the build farm with rosdep.

Tracked issue:

• vcs2l fails with scenario_simulator_v2 autowarefoundation/autoware#6652