fix(macos): stabilize startup (db & ipc & early rpc) initialization#1472
Open
amirHdev wants to merge 1 commit into
Open
fix(macos): stabilize startup (db & ipc & early rpc) initialization#1472amirHdev wants to merge 1 commit into
amirHdev wants to merge 1 commit into
Conversation
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
|
Thanks. All work ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes a set of macOS startup failures that were happening at different stages of application initialization.
The first issue was database startup using a path derived from the app bundle before the runtime had switched to a writable application data directory which caused SQLite initialization to fail on macOS. the second issue was instance IPC setup via QLocalServer where the original naming and socket path strategy was not reliable for macOS runtime conditions. the third issue was an early UI status refresh path calling into privilege detection before the RPC client had been initialized which led to a null dereference during startup.
The bug I faced with: for db startup one:
bug.txt
Fixes #1352