Fix mutable default arguments bug in Communication class - #912
Open
l1ve709 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a critical Python anti-pattern (B006: mutable default arguments) in the
Communicationclass initialization (routersploit/core/exploit/shell.py).Previously,
wget_optionsandecho_optionswere initialized with an empty dictionary{}. Because default arguments in Python are evaluated once at function definition, multiple exploit module instances could end up sharing the exact same dictionary reference in memory. This can lead to state leakage across modules (where configuring an option for one target inadvertently affects another target).This fix replaces the mutable
{}defaults withNone, and explicitly creates a fresh dictionary inside the constructor__init__if no argument is passed, guaranteeing proper memory isolation for each instance.Modules affected
routersploit/core/exploit/shell.py