Skip to content

⚡ [performance improvement] Use Buffer.allocUnsafe for VBANChatPacket.toUDPPacket #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
google-labs-jules wants to merge 3 commits into
base: main
Choose a base branch
from
Open

⚡ [performance improvement] Use Buffer.allocUnsafe for VBANChatPacket.toUDPPacket #464

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c97f954
perf: use Buffer.allocUnsafe for VBANChatPacket toUDPPacket
google-labs-jules[bot] Jun 13, 2026
9ef20ad
perf: use Buffer.allocUnsafe for VBANChatPacket toUDPPacket
google-labs-jules[bot] Jun 13, 2026
92a3306
perf: use Buffer.allocUnsafe for VBANChatPacket toUDPPacket
google-labs-jules[bot] Jun 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/packets/VBANServicePacket/subPackets/VBANChatPacket.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,13 @@ export class VBANChatPacket extends VBANServicePacket {

public static toUDPPacket(packet: VBANChatPacket): Buffer {
// 704 is the size for a service packet
const dataBuffer = Buffer.alloc(676);
dataBuffer.write(prepareStringForPacket(packet.data, 676), 0, 'utf8');
// Use allocUnsafe for performance as the buffer is fully overwritten below.
// This avoids zero-filling the memory.
const dataBuffer = Buffer.allocUnsafe(676);
const written = dataBuffer.write(prepareStringForPacket(packet.data, 676), 0, 'utf8');
if (written < 676) {
dataBuffer.fill(0, written);
}

return this.convertToUDPPacket(
{
Expand Down
Loading