Implement stricter parsing to avoid skipping invalid lines#609
Open
a2Fsa2k wants to merge 1 commit into
Open
Conversation
Adds a `createStrictParser()` that reports unexpected text as parse-failed errors instead of silently skipping it. Useful for debugging when LLMs generate preamble text alongside valid openui-lang statements. Changes: - Add `tokenText()` utility to reconstruct text from tokens - `split()` now collects skipped line text when a collector is provided - Add `createStrictParser()` and `strict` parameter to `parse()` - Add "parse-failed" to ValidationErrorCode - Add test coverage for strict mode Closes thesysdev#582
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds strict mode to the openui-lang parser so that invalid lines (lines
that don't match
identifier = expression) are reported asparse-failederrors instead of being silently skipped. Useful for debugging when LLMs
generate preamble text alongside valid openui-lang code.
Changes
tokenText()utility to reconstruct text from a tokensplit()now accepts an optionalskippedarray tocollect skipped line text
strictparameter toparse(), and newcreateStrictParser()API that surfaces skipped lines as errors"parse-failed"toValidationErrorCodeExample
Closes #582