Skip to content

fix: adapt misleading routing info in admin logs #1949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
steebchen-bot wants to merge 3 commits into from
Closed

fix: adapt misleading routing info in admin logs #1949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e3f83f
Routing: retry model attribution fix + provider match update
steebchen-bot Apr 1, 2026
a20aff1
fix: clarify selected routing entry in admin logs
steebchen-bot Apr 1, 2026
73b3824
chore: merge origin/main, resolve conflicts
steebchen-bot May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 17 additions & 11 deletions apps/gateway/src/chat/chat.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4746,7 +4746,7 @@ chat.openapi(completions, async (c) => {
routingAttempts.push(
buildRoutingAttempt(
usedProvider,
baseModelName,
usedModelMapping,
0,
getErrorType(0),
false,
Expand Down Expand Up @@ -5082,7 +5082,7 @@ chat.openapi(completions, async (c) => {
routingAttempts.push(
buildRoutingAttempt(
usedProvider,
baseModelName,
usedModelMapping,
0,
getErrorType(0),
false,
Expand Down Expand Up @@ -5322,7 +5322,7 @@ chat.openapi(completions, async (c) => {
routingAttempts.push(
buildRoutingAttempt(
usedProvider,
baseModelName,
usedModelMapping,
res.status,
getErrorType(res.status),
false,
Expand Down Expand Up @@ -5621,7 +5621,7 @@ chat.openapi(completions, async (c) => {
routingAttempts.push(
buildRoutingAttempt(
usedProvider,
baseModelName,
usedModelMapping,
res.status,
"none",
true,
Expand All @@ -5640,13 +5640,15 @@ chat.openapi(completions, async (c) => {
const failedMap = new Map(
routingAttempts
.filter((a) => !a.succeeded)
.map((f) => [f.provider, f]),
.map((f) => [providerRetryKey(f.provider, f.region), f]),
);
routingMetadata = {
...routingMetadata,
routing: routingAttempts,
providerScores: routingMetadata.providerScores.map((score) => {
const failure = failedMap.get(score.providerId);
const failure = failedMap.get(
providerRetryKey(score.providerId, score.region),
);
if (failure) {
return {
...score,
Expand Down Expand Up @@ -8325,7 +8327,7 @@ chat.openapi(completions, async (c) => {
routingAttempts.push(
buildRoutingAttempt(
usedProvider,
baseModelName,
usedModelMapping,
0,
getErrorType(0),
false,
Expand Down Expand Up @@ -8809,7 +8811,7 @@ chat.openapi(completions, async (c) => {
routingAttempts.push(
buildRoutingAttempt(
usedProvider,
baseModelName,
usedModelMapping,
res.status,
getErrorType(res.status),
false,
Expand Down Expand Up @@ -8896,7 +8898,7 @@ chat.openapi(completions, async (c) => {
routingAttempts.push(
buildRoutingAttempt(
usedProvider,
baseModelName,
usedModelMapping,
res.status,
"none",
true,
Expand All @@ -8913,13 +8915,17 @@ chat.openapi(completions, async (c) => {
if (routingMetadata) {
// Enrich providerScores with failure info from routing attempts
const failedMap = new Map(
routingAttempts.filter((a) => !a.succeeded).map((f) => [f.provider, f]),
routingAttempts
.filter((a) => !a.succeeded)
.map((f) => [providerRetryKey(f.provider, f.region), f]),
);
routingMetadata = {
...routingMetadata,
routing: routingAttempts,
providerScores: routingMetadata.providerScores.map((score) => {
const failure = failedMap.get(score.providerId);
const failure = failedMap.get(
providerRetryKey(score.providerId, score.region),
);
if (failure) {
return {
...score,
Expand Down
205 changes: 131 additions & 74 deletions packages/shared/src/components/log-card.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ import {

interface RoutingMetadata {
selectionReason?: string;
selectedProvider?: string;
usedApiKeyHash?: string;
availableProviders?: string[];
xNoFallbackHeaderSet?: boolean;
Expand Down Expand Up @@ -214,6 +215,10 @@ function formatDuration(ms: number) {
return `${(ms / 1000).toFixed(2)}s`;
}

function getRoutingEntryKey(provider: string, region?: string) {
return region ? `${provider}:${region}` : provider;
}

function formatApiKeyHash(hash: string) {
return hash.slice(0, 7);
}
Expand Down Expand Up @@ -369,6 +374,37 @@ export function LogCard({
log.dataStorageCost !== undefined &&
Number(log.dataStorageCost) > 0;
const [isExpanded, setIsExpanded] = useState(false);

const selectedRoutingAttempt = routingMetadata?.routing
?.slice()
.reverse()
.find((attempt) => attempt.succeeded);
const selectedRoutingProvider =
selectedRoutingAttempt?.provider ??
routingMetadata?.selectedProvider ??
log.usedProvider;
const selectedRoutingKey = getRoutingEntryKey(
selectedRoutingAttempt?.provider ?? selectedRoutingProvider ?? "",
selectedRoutingAttempt?.region,
);
const sortedProviderScores = routingMetadata?.providerScores
? [...routingMetadata.providerScores].sort((a, b) => {
const aSelected =
getRoutingEntryKey(a.providerId, a.region) === selectedRoutingKey;
const bSelected =
getRoutingEntryKey(b.providerId, b.region) === selectedRoutingKey;
if (aSelected !== bSelected) {
return aSelected ? -1 : 1;
}
const aScore = a.score >= 0 ? a.score : Number.POSITIVE_INFINITY;
const bScore = b.score >= 0 ? b.score : Number.POSITIVE_INFINITY;
if (aScore !== bScore) {
return aScore - bScore;
}
return a.providerId.localeCompare(b.providerId);
})
: [];

const [imagePreviewOpen, setImagePreviewOpen] = useState(false);
const [imagePreviewSrcs, setImagePreviewSrcs] = useState<string[]>([]);
const [imagePreviewTitle, setImagePreviewTitle] = useState("Generated Image");
Expand Down Expand Up @@ -659,86 +695,107 @@ export function LogCard({
</span>
</div>
)}
{routingMetadata.providerScores &&
routingMetadata.providerScores.length > 0 && (
<div className="pt-1 border-t border-dashed">
<div className="text-muted-foreground mb-1">
Scores
{selectedRoutingProvider && (
<div className="flex justify-between">
<span className="text-muted-foreground">Selected</span>
<span className="font-mono">
{selectedRoutingProvider}
</span>
</div>
)}
{sortedProviderScores.length > 0 && (
<div className="pt-1 border-t border-dashed">
<div className="flex justify-between gap-2 mb-1">
<div className="text-muted-foreground">Scores</div>
<div className="text-[11px] text-muted-foreground">
lower is better
</div>
<div className="space-y-1">
{routingMetadata.providerScores.map((score) => (
<div
key={`${score.providerId}-${score.region ?? "default"}`}
className="flex justify-between items-center"
>
<span className="font-mono flex items-center gap-1.5">
{score.providerId}
{score.region && (
<span className="text-muted-foreground">
({score.region})
</span>
)}
{score.failed && (
<span className="inline-flex items-center gap-0.5 text-red-500">
<AlertCircle className="h-3 w-3" />
<span>
{score.status_code}
{score.error_type && (
<span className="ml-0.5 text-red-400">
{score.error_type}
</span>
)}
</span>
</span>
)}
{score.rate_limited && (
<span className="inline-flex items-center gap-0.5 text-amber-500">
<Clock className="h-3 w-3" />
<span>rpm capped</span>
</span>
)}
{score.excludedByContentFilter && (
<span className="inline-flex items-center gap-0.5 text-amber-500">
<Ban className="h-3 w-3" />
<span>content filter</span>
</span>
)}
</span>
<span className="text-muted-foreground font-mono">
{score.score.toFixed(2)}
{score.uptime !== undefined && (
<span className="ml-2">
↑{score.uptime?.toFixed(0)}%
</span>
)}
{score.throughput !== undefined && (
<span className="ml-2">
{score.throughput?.toFixed(0)}t/s
</div>
<div className="space-y-1">
{sortedProviderScores.map((score) => (
<div
key={`${score.providerId}-${score.region ?? "default"}`}
className="flex justify-between items-center"
>
<span className="font-mono flex items-center gap-1.5">
{score.providerId}
{getRoutingEntryKey(
score.providerId,
score.region,
) === selectedRoutingKey && (
<Badge
variant="outline"
className="h-4 px-1 text-[10px]"
>
selected
</Badge>
)}
{score.region && (
<span className="text-muted-foreground">
({score.region})
</span>
)}
{score.failed && (
<span className="inline-flex items-center gap-0.5 text-red-500">
<AlertCircle className="h-3 w-3" />
<span>
{score.status_code}
{score.error_type && (
<span className="ml-0.5 text-red-400">
{score.error_type}
</span>
)}
</span>
)}
{score.latency !== undefined && (
</span>
)}
{score.rate_limited && (
<span className="inline-flex items-center gap-0.5 text-amber-500">
<Clock className="h-3 w-3" />
<span>rpm capped</span>
</span>
)}
{score.excludedByContentFilter && (
<span className="inline-flex items-center gap-0.5 text-amber-500">
<Ban className="h-3 w-3" />
<span>content filter</span>
</span>
)}
</span>
<span className="text-muted-foreground font-mono">
{score.score.toFixed(2)}
{score.uptime !== undefined && (
<span className="ml-2">
↑{score.uptime?.toFixed(0)}%
</span>
)}
{score.throughput !== undefined && (
<span className="ml-2">
{score.throughput?.toFixed(0)}t/s
</span>
)}
{score.latency !== undefined && (
<span className="ml-2">
{score.latency?.toFixed(0)}ms
</span>
)}
{score.price !== undefined && (
<span className="ml-2">${score.price}</span>
)}
{score.priority !== undefined &&
score.priority !== 1 && (
<span className="ml-2">
{score.latency?.toFixed(0)}ms
p:{score.priority}
</span>
)}
{score.price !== undefined && (
<span className="ml-2">${score.price}</span>
)}
{score.priority !== undefined &&
score.priority !== 1 && (
<span className="ml-2">
p:{score.priority}
</span>
)}
{score.cacheSupported && (
<span className="ml-2">cache</span>
)}
</span>
</div>
))}
</div>
{score.cacheSupported && (
<span className="ml-2">cache</span>
)}
</span>
</div>
))}
</div>
)}
</div>
)}
{routingMetadata.routing &&
routingMetadata.routing.length > 0 && (
<div className="pt-1 border-t border-dashed">
Expand Down
Loading