Adds per-axis bin counts feature in GridPartition#296
Open
dhruvDev23 wants to merge 3 commits intotheochem:mainfrom
Open
Adds per-axis bin counts feature in GridPartition#296dhruvDev23 wants to merge 3 commits intotheochem:mainfrom
dhruvDev23 wants to merge 3 commits intotheochem:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the feature mentioned by @FarnazH in this comment.
Currently all axes in
GridPartitionare forced to use name number of bins, This feature allow users to specify different number of bins for each feature dimension.Tests: Adds 4 new test functions in
test_partition.pycovering:nbins_axis.ValueErroris raised for mismatched list lengths.nbins_axis=5produces identical results tonbins_axis=[5, 5].