Conversation
shewa12
reviewed
Apr 15, 2026
| * | ||
| * @return object|null | ||
| */ | ||
| private function get_attempt_answer_by_attempt_and_question( int $attempt_id, int $question_id ) { |
Collaborator
There was a problem hiding this comment.
There is already a method for fetching attempt: tutor_utils()->get_attempt( $attempt_id )
Collaborator
Author
There was a problem hiding this comment.
We still need get_attempt_answer_by_attempt_and_question() because creating a placeholder row is only correct when no answer row already exists for the same attempt_id + question_id. In the skipped legacy case there is no attempt_answer_id, so the review flow first has to look up by attempt_id and question_id: if a row exists we should update it, and if not we create the missing row and then apply the review. Without that lookup the fallback becomes a blind insert, which can create duplicate attempt-answer rows for questions that already have a saved record.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
is_attempt_answer_skipped()helper methodreview_quiz_answer()to handle skipped questionsstatus_badgesarray for multiple status badges in question headersquestion_iddata attribute for manual review actions'incorrect'consistentlyCommits