This repository was archived by the owner on Feb 19, 2021. It is now read-only.
Don't parse dates with more than 4 digits for the year#556
Open
heinrich5991 wants to merge 2 commits intothe-paperless-project:masterfrom
Open
Don't parse dates with more than 4 digits for the year#556heinrich5991 wants to merge 2 commits intothe-paperless-project:masterfrom
heinrich5991 wants to merge 2 commits intothe-paperless-project:masterfrom
Conversation
The regex was broken before, using `(?!…)` instead of `(?<=…)`.
skius
previously approved these changes
Aug 19, 2019
Contributor
|
Why do we need to lookbehind and lookahead? Can't we get away with something like this? r = re.compile(r'(?:\b|[_-])('\
r'(?:[0-9]{1,2}[./-][0-9]{1,2}[./-](?:[0-9]{4}|[0-9]{2}))|'\
r'(?:(?:[0-9]{4}|[0-9]{2})[./-][0-9]{1,2}[./-][0-9]{1,2})|'\
r'(?:[0-9]{1,2}\. +[^\W\d_]{3,9} (?:[0-9]{4}|[0-9]{2}))|'\
r'(?:[^\W\d_]{3,9}(?: [0-9]{1,2},)? [0-9]{4})'\
r')(?:\b|[_-])')In some manual testing, it seems to match everything matched in the unit tests. We can then use 👍 for the additional tests. |
Author
|
Updated with the suggestion to not use lookahead/lookbehind. |
Author
|
Removed all the superfluous |
Contributor
Great, could you also remove the superfluous |
MasterofJOKers
previously approved these changes
Nov 2, 2019
1984972 to
a268199
Compare
Author
|
Removed the superfluous backslashes in the regex. |
MasterofJOKers
approved these changes
Nov 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The regex was broken before, using
(?!…)instead of(?<=…).