This repository was archived by the owner on Feb 19, 2021. It is now read-only.
WIP: Logging configuration#496
Open
ovv wants to merge 5 commits intothe-paperless-project:masterfrom
Open
Conversation
5cb2a16 to
26b4089
Compare
Collaborator
|
This is all good stuff, and I just have a few notes:
|
Collaborator
|
Further to 1️⃣ above, would it be altogether crazy to set an environment variable to a JSON value that would represent the logging config? It'd be ugly, but at least more portable. Something like: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Putting it out here to get feedback on the approach.
I figured adding a file to configure the whole of logging would be better than individual option (See #495 ).
I'm not sure how to best name the file, creating a
paperlessdirectory and simply naming itlogging.ymlseems fine but it changes where the configuration should be located.I still need to do some more tests and write some documentation