scripts: remove deprecated GO111MODULE=on#8789
Closed
mr-raj12 wants to merge 1 commit intothanos-io:mainfrom
Closed
scripts: remove deprecated GO111MODULE=on#8789mr-raj12 wants to merge 1 commit intothanos-io:mainfrom
mr-raj12 wants to merge 1 commit intothanos-io:mainfrom
Conversation
GO111MODULE is ignored on Go 1.21+ and this repo declares go 1.26.0 in go.mod. The inline prefix on go list calls in genproto.sh and insecure_grpcurl_series.sh is dead code - remove it. Signed-off-by: Mrityunjay Raj <mr.raj.earth@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the
GO111MODULE=oninline prefix from two shell scripts:scripts/genproto.shscripts/insecure_grpcurl_series.shWhy
GO111MODULEhas been ignored since Go 1.21 - setting it has no effect. This repo declaresgo 1.26.0ingo.mod, so the prefix is dead code in both scripts.Module mode has been the default since Go 1.16, and the env var was fully deprecated in Go 1.21. Leaving it around creates a false impression that it is doing something.
References