Repository navigation
nginx add - #9
Conversation
There was a problem hiding this comment.
💡 Codex Review
Lines 103 to 105 in 7adb237
The A/B location proxies with proxy_pass http://app_$ab_bucket; to select app_stable or app_beta. When proxy_pass contains a variable, NGINX does not use previously defined upstream blocks; it treats the expanded value as a literal hostname and attempts DNS resolution (and disables keepalive). Unless there are DNS records for app_beta/app_stable, requests will 502 with “no resolver defined to resolve app_beta”. Use static proxy_pass directives (e.g. if/map to full URLs) to keep using the configured upstream groups.
Lines 111 to 112 in 7adb237
The multi‑tenant location proxies with proxy_pass http://$tenant_upstream;, expecting $tenant_upstream to resolve to app_cluster_1 or app_cluster_2. As with the A/B block, variables in proxy_pass are resolved as hostnames, not upstream group identifiers, so these names will not match the upstream definitions and the proxy returns 502 (or disables upstream features) unless matching DNS records exist. Map tenants to explicit proxy_pass http://app_cluster_1;/app_cluster_2; blocks or use a resolver-backed hostname.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
No description provided.