Skip to content

Add missing TLS signature schemes#3021

Merged
drwetter merged 1 commit intotestssl:3.3devfrom
dcooper16:missing_sigschemes
Apr 13, 2026
Merged

Add missing TLS signature schemes#3021
drwetter merged 1 commit intotestssl:3.3devfrom
dcooper16:missing_sigschemes

Conversation

@dcooper16
Copy link
Copy Markdown
Collaborator

Describe your changes

This PR fixes a few places where new signature schemes were not added:

  1. It adds ECDSA with the Brainpool curves for TLS 1.3 (0x081a, 0x081b, and 0x081c) to get_server_certificate(), certificate_transparency(), and prepare_tls_clienthello().

  2. It adds rsa_pss_pss (0x0809, 0x080a, 0x080b) to certificate_transparency().

  3. It adds the signature schemes for EdDSA (0x0807, 0x0808) and ML-DSA (0x0904, 0x0905, 0x0906) to certificate_transparency().

What is your pull request about?

  • Bug fix
  • Improvement
  • New feature (adds functionality)
  • Breaking change (bug fix, feature or improvement that would cause existing functionality to not work as expected)
  • Typo fix
  • Documentation update
  • Update of other files

If it's a code change please check the boxes which are applicable

  • For the main program: My edits contain no tabs, indentation is five spaces and any line endings do not contain any blank chars
  • I've read CONTRIBUTING.md and Coding_Convention.md
  • I have tested this fix or improvement against >=2 hosts and I couldn't spot a problem
  • I have tested this new feature against >=2 hosts which show this feature and >=2 host which does not (in order to avoid side effects) . I couldn't spot a problem
  • For the new feature I have made corresponding changes to the documentation and / or to help()
  • If it's a bigger change: I added myself to CREDITS.md (alphabetical order) and the change to CHANGELOG.md

This commit fixes a few places where new signature schemes were not added:

1) It adds ECDSA with the Brainpool curves for TLS 1.3 (0x081a, 0x081b, and 0x081c) to get_server_certificate(), certificate_transparency(), and prepare_tls_clienthello().

2) It adds rsa_pss_pss (0x0809, 0x080a, 0x080b) to certificate_transparency().

3) It adds the signature schemes for EdDSA (0x0807, 0x0808) and ML-DSA (0x0904, 0x0905, 0x0906) to certificate_transparency().
@drwetter drwetter merged commit 93ae5d7 into testssl:3.3dev Apr 13, 2026
4 checks passed
@drwetter
Copy link
Copy Markdown
Collaborator

thanks!

@dcooper16 dcooper16 deleted the missing_sigschemes branch April 13, 2026 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants