fix(title): find nested SVG title elements - #1384
Open
xianjianlf2 wants to merge 1 commit into
Open
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8d52080:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Allow
ByTitlequeries to match SVG<title>elements nested below SVG graphics/container elements, not only directsvg > titlechildren.Why
SVG titles can be attached to nested graphics elements such as
<path><title>...</title></path>. The previous selector only considered direct children of<svg>, sogetByTitlecould not find those valid nested title elements.Fixes #974
Validation
npm test -- --runTestsByPath src/__tests__/element-queries.js --runInBand --watch=falseNote: the full local
validatestep is currently blocked in this checkout by@types/node/ffi.d.tssyntax errors from the repository's dependency/TypeScript version combination, before this PR's code is involved.