Skip to content

Add scripts/ to directories checked by format_all.sh#1046

Merged
mhucka merged 7 commits intotensorflow:masterfrom
mhucka:also-format-scripts
Apr 18, 2026
Merged

Add scripts/ to directories checked by format_all.sh#1046
mhucka merged 7 commits intotensorflow:masterfrom
mhucka:also-format-scripts

Conversation

@mhucka
Copy link
Copy Markdown
Member

@mhucka mhucka commented Apr 14, 2026

The format_all.sh script did not format files in the scripts/ directory. However, it makes sense to format those scripts according to project conventions too. This PR adds the scripts/ directory to the directories passed to yapf in scripts/format_all.sh.

This PR also includes a couple of small changes to scripts/build_docs.py (add a docstring, remove some whitespace), which are the result of running format_all.sh on the scripts/ directory.

mhucka added 4 commits April 14, 2026 20:04
The `format_all.sh` script didn't format files in the `scripts/`
directory.
Until the PR for adding .style.yapf is added, the scripts need to supply
the style argument.
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cleans up whitespace in scripts/build_docs.py and extends the Python formatting script scripts/format_all.sh to cover the scripts/ directory. I have no feedback to provide.

mhucka added 3 commits April 14, 2026 20:22
Instead of invoking yapf on each directory separately, running it in one
invocation with the parallel flag is considerably faster.
@mhucka mhucka marked this pull request as ready for review April 15, 2026 01:04
@mhucka mhucka requested a review from MichaelBroughton April 15, 2026 01:04
@mhucka mhucka changed the title Make format_all.sh run on the scripts/ directory too Add scripts/ to directories checked by format_all.sh Apr 15, 2026
@mhucka mhucka added the area/devops Involves build systems, Make files, Bazel files, continuous integration, and/or other DevOps topics label Apr 16, 2026
@mhucka mhucka merged commit 72282d1 into tensorflow:master Apr 18, 2026
10 checks passed
@mhucka mhucka deleted the also-format-scripts branch April 18, 2026 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/devops Involves build systems, Make files, Bazel files, continuous integration, and/or other DevOps topics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants