Skip to content

fix(a11y): pair Toast variant background with a severity icon (WCAG 1.4.1) #3449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bilal-karim wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(a11y): pair Toast variant background with a severity icon (WCAG 1.4.1) #3449

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b36530f
fix(a11y): pair Toast variant background with a severity icon (WCAG 1…
bilal-karim May 25, 2026
04521eb
fix(types): narrow Icon name from IconName|null via reactive var
bilal-karim May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/lib/holocene/toast.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import { createEventDispatcher } from 'svelte';
import { twMerge as merge } from 'tailwind-merge';

import type { IconName } from '$lib/holocene/icon';
import Icon from '$lib/holocene/icon/icon.svelte';
import type { ToastVariant } from '$lib/types/holocene';

Expand All @@ -17,10 +18,20 @@
warning: 'bg-warning',
};

const variantIcon: Readonly<Record<ToastVariant, IconName | null>> = {
primary: null,
success: 'success',
error: 'error',
info: 'info',
warning: 'warning',
};

export let id: string;
export let variant: keyof typeof variants;
export let closeButtonLabel: string;

$: icon = variantIcon[variant];

const handleDismiss = () => {
dispatch('dismiss', { id });
};
Expand All @@ -34,6 +45,9 @@
)}
transition:fly={{ x: 250 }}
>
{#if icon}
<Icon name={icon} class="shrink-0" />
{/if}
<p class="text-sm">
<slot />
</p>
Expand Down
Loading