Skip to content

Add azure_pe_resource_id field to PrivateConnectivityRule #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
k24dizzle wants to merge 1 commit into from
Closed

Add azure_pe_resource_id field to PrivateConnectivityRule #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions temporal/api/cloud/connectivityrule/v1/message.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,16 +53,25 @@ message PublicConnectivityRule {

// A private connectivity rule allows connections from a specific private vpc only.
message PrivateConnectivityRule {
// Connection id provided to enforce the private connectivity. This is required both by AWS and GCP.
// Connection id provided to enforce the private connectivity.
// For AWS: VPC endpoint ID (e.g. "vpce-0123456789abcdef0").
// For GCP: PSC connection ID (numeric string).
// For Azure: not set by the customer; populated internally with the PPv2 LinkID
// returned by the infra plane during Private Endpoint connection approval.
string connection_id = 1;

// For GCP private connectivity service, GCP needs both GCP project id and the Private Service Connect Connection IDs
// AWS only needs the connection_id
string gcp_project_id = 2;

// The region of the connectivity rule. This should align with the namespace.
// Example: "aws-us-west-2"
// Example: "aws-us-west-2", "gcp-us-central1", "azure-eastus"
string region = 3;

reserved 4;

// The ARM resource ID of the customer's Azure Private Endpoint.
// Required for Azure private connectivity rules.
// Example: "/subscriptions/{sub}/resourceGroups/{rg}/providers/Microsoft.Network/privateEndpoints/{name}"
string azure_pe_resource_id = 5;
}
Loading