[don't merge] just for review#786
Open
feiyang3cat wants to merge 1 commit into
Open
Conversation
feiyang3cat
force-pushed
the
patch/ts
branch
2 times, most recently
from
0343fc1 to
64911c4
Compare
Replace the max_skipped_duration / max_elapsed_duration oneof on TimeSkippingConfig with value / delta. Add MaxSkip (configured + remaining) to WorkflowExecutionTimeSkippingTransitionedEventAttributes so consumers can observe both the configured bound and how much skip time remains. Drop buf-breaking from the Makefile grpc target while this unreleased API is still in flux; regenerate openapi to match the new proto. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
maxElapsedDuration— considered redundant given overlapping functionalitymaxSkippedDuration, changed its structure, exposed current max skip duration and remaining duration in the time-skipping transitioned eventWhy?
Breaking changes
maxElapsedDuration-> the server has already implemented this featuremaxSkippedDuration-> the server has used the old data structure for its implementationServer PR
TBD if the change in the PR is good option and no better option can be found