feat(e2e): add Postgres DB layer e2e test suite by adityavshinde · Pull Request #1477 · tektoncd/results

adityavshinde · 2026-09-02T09:58:01Z

Changes

Add Postgres-specific e2e test suite (test/e2e/db/) that exercises database
behavior the SQLite-backed unit tests cannot reach: pgconn.PgError SQLSTATE
error mapping, jsonb column types and operators, CEL -> SQL filter/sort/pagination
on real Postgres, FK cascade, and schema correctness.

Tests run against the deployed API server in the kind cluster and its live
Postgres instance via gRPC - not an in-process server or throwaway database.

What's included:

Error mapping tests (unique violation, FK violation, stale etag, NotFound, cascade delete)
Schema validation (column types, PKs, unique indexes, FKs, jsonb @>)
Lister contract tests (filter, order, pagination with pageSize≥5, ListRecords)
Placeholder stubs with t.Skip for future stories (labels, migrations, relationships, retention)
Shared client config extracted to test/e2e/client/config.go (eliminates duplication between e2e_test.go and db_test.go)
CI wiring in e2e.sh: port-forward on 15432, DB_URL env var, password suppressed from traces, cleanup on failure
test/e2e/README.md and test/e2e/db/README.md updated/created

/kind feature

Submitter Checklist

Has Docs included if any changes are user facing
Has Tests included if any functionality added or changed
Tested your changes locally (if this is a code change)
Follows the commit message standard
Meets the Tekton contributor standards (including functionality, content, code)
Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

tekton-robot · 2026-09-02T09:58:05Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign khrm after the PR has been reviewed.
You can assign the PR to them by writing /assign @khrm in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copilot

🟡 Changes recommended

Several assertions can produce false positives and do not fully validate the advertised database behavior.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds PostgreSQL-specific end-to-end coverage against the deployed API server and live database.

Changes:

Adds schema, error-mapping, filtering, sorting, and pagination tests.
Centralizes e2e client configuration.
Wires database tests and PostgreSQL port-forwarding into CI.

File summaries

File	Description
`test/e2e/README.md`	Documents database tests.
`test/e2e/e2e.sh`	Runs database tests against port-forwarded PostgreSQL.
`test/e2e/e2e_test.go`	Uses shared client configuration.
`test/e2e/e2e_gcs_test.go`	Updates shared token usage.
`test/e2e/client/config.go`	Adds reusable client environment and TLS configuration.
`test/e2e/db/README.md`	Documents database suite setup and scope.
`test/e2e/db/db_test.go`	Initializes API clients and database connection.
`test/e2e/db/error_mapping_test.go`	Tests PostgreSQL error translation and cascades.
`test/e2e/db/lister_test.go`	Tests filtering, ordering, and pagination.
`test/e2e/db/schema_test.go`	Validates live PostgreSQL schema behavior.
`test/e2e/db/labels_test.go`	Adds future label-test placeholders.
`test/e2e/db/migrations_test.go`	Adds future migration-test placeholders.
`test/e2e/db/relationships_test.go`	Adds future relationship-test placeholders.
`test/e2e/db/retention_test.go`	Adds future retention-test placeholder.

Review details

Files reviewed: 14/14 changed files
Comments generated: 2
Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

khrm · 2026-09-10T04:54:47Z

+		t.Fatalf("ListResults with ORDER BY ASC failed: %v", err)
+	}
+
+	for i := 1; i < len(resp.Results); i++ {


We should also assert the length of the results returned.

khrm · 2026-09-10T05:04:32Z


+run_db_tests() {
+    REPO="$1"
+    local LOCAL_PG_PORT=15432


Instead of hardcoding this, we should have something like "${PG_E2E_PORT:-15432}" Otherwise, only one test can be run, not parallel run with multiple PG instances..

khrm · 2026-09-10T05:10:16Z

+	})
+	if err != nil {
+		t.Fatalf("CreateResult failed: %v", err)
+	}


Why no cleanup here? If there's a failure, then there's leak. In case of pass, that cleanup can be a no ops.

Copilot

🟡 Changes recommended

The HA-tagged test suite references a removed token constant and therefore cannot compile.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

Files reviewed: 14/14 changed files
Comments generated: 1
Review effort level: Balanced

adityavshinde · 2026-09-10T07:26:58Z

-	defaultCertPath                             = "/tmp/tekton-results/ssl"
-	defaultTokenPath                            = "/tmp/tekton-results/tokens"
-	defaultNamespace                            = "default"
+	allNamespacesReadAccessToken        = "all-namespaces-read-access"


khrm · 2026-09-10T05:19:47Z

+|---|---|---|
+| `DB_URL` | (none) | Full Postgres DSN. When set, takes precedence over individual `POSTGRES_*` vars. The `e2e.sh` script constructs this automatically. |
+| `POSTGRES_HOST` | `localhost` | Fallback: Postgres host (via port-forward) |
+| `POSTGRES_PORT` | `15432` | Fallback: local forwarded port |


I see that you multiple vars here. Can you check whether you are using these var with default value in the script?

The POSTGRES_* variables are used as fallbacks in db_test.go's buildDSN() for manual runs when DB_URL is not set, the e2e.sh CI script always constructs DB_URL directly, so these individual vars are never used in the CI path. I am mentioning this in README.md file only.

- Add DB layer e2e tests (error mapping, schema validation, lister behavior) under test/e2e/db/ with build tag e2e - Fix seedResults in lister_test.go: lowercase status names to match API name regex, populate mandatory Summary.Record and Summary.Type - Remove InsecureSkipVerify TLS fallback in test/e2e/client/config.go to resolve CodeQL critical alert; fail explicitly on missing certs - Add run_db_tests function in e2e.sh with port-forward and DB_URL setup; exclude db tests from main e2e run - Fix stale variable reference in e2e_gcs_test.go: allNamespacesReadAccessTokenFile to allNamespacesReadAccessToken

tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesnt merit a release note. labels Sep 2, 2026

tekton-robot requested review from enarha and khrm September 2, 2026 09:58

tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 2, 2026

adityavshinde changed the title ~~test harness for postgres e2e db layer~~ feat(e2e): add Postgres DB layer e2e test suite Sep 2, 2026

github-advanced-security Bot found potential problems Sep 2, 2026

View reviewed changes

Comment thread test/e2e/client/config.go Fixed

adityavshinde force-pushed the test/postgres-e2e-db-layer branch 3 times, most recently from debdf91 to f5fb456 Compare September 2, 2026 12:19

enarha requested a balanced review from Copilot September 8, 2026 12:24

Copilot started reviewing on behalf of enarha September 8, 2026 12:25 View session

Copilot AI reviewed Sep 8, 2026

View reviewed changes

Comment thread test/e2e/db/lister_test.go Outdated

Comment thread test/e2e/db/schema_test.go

tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 8, 2026

adityavshinde force-pushed the test/postgres-e2e-db-layer branch from f5fb456 to 6ffaafb Compare September 9, 2026 06:59

tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 9, 2026

khrm reviewed Sep 10, 2026

View reviewed changes

Comment thread test/e2e/client/config.go

khrm reviewed Sep 10, 2026

View reviewed changes

khrm requested a balanced review from Copilot September 10, 2026 05:10

Copilot started reviewing on behalf of khrm September 10, 2026 05:12 View session

Copilot AI reviewed Sep 10, 2026

View reviewed changes

khrm reviewed Sep 10, 2026

View reviewed changes

adityavshinde force-pushed the test/postgres-e2e-db-layer branch from 6ffaafb to 3cac059 Compare September 10, 2026 07:20

Uh oh!

Conversation

adityavshinde commented Sep 2, 2026

Changes

Submitter Checklist

Release Notes

Uh oh!

tekton-robot commented Sep 2, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants