feat(e2e): add Postgres DB layer e2e test suite - #1477
Open
adityavshinde wants to merge 1 commit into
Open
Conversation
tekton-robot
added
kind/feature
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
tekton-robot
added
the
size/XXL
adityavshinde
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
adityavshinde
force-pushed
the
test/postgres-e2e-db-layer
branch
2 times, most recently
from
September 2, 2026 11:52
f610774 to
debdf91
Compare
- Add DB layer e2e tests (error mapping, schema validation, lister behavior) under test/e2e/db/ with build tag e2e - Fix seedResults in lister_test.go: lowercase status names to match API name regex, populate mandatory Summary.Record and Summary.Type - Remove InsecureSkipVerify TLS fallback in test/e2e/client/config.go to resolve CodeQL critical alert; fail explicitly on missing certs - Add run_db_tests function in e2e.sh with port-forward and DB_URL setup; exclude db tests from main e2e run - Fix stale variable reference in e2e_gcs_test.go: allNamespacesReadAccessTokenFile to allNamespacesReadAccessToken
adityavshinde
force-pushed
the
test/postgres-e2e-db-layer
branch
from
September 2, 2026 12:19
debdf91 to
f5fb456
Compare
There was a problem hiding this comment.
🟡 Changes recommended
Several assertions can produce false positives and do not fully validate the advertised database behavior.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds PostgreSQL-specific end-to-end coverage against the deployed API server and live database.
Changes:
- Adds schema, error-mapping, filtering, sorting, and pagination tests.
- Centralizes e2e client configuration.
- Wires database tests and PostgreSQL port-forwarding into CI.
File summaries
| File | Description |
|---|---|
test/e2e/README.md |
Documents database tests. |
test/e2e/e2e.sh |
Runs database tests against port-forwarded PostgreSQL. |
test/e2e/e2e_test.go |
Uses shared client configuration. |
test/e2e/e2e_gcs_test.go |
Updates shared token usage. |
test/e2e/client/config.go |
Adds reusable client environment and TLS configuration. |
test/e2e/db/README.md |
Documents database suite setup and scope. |
test/e2e/db/db_test.go |
Initializes API clients and database connection. |
test/e2e/db/error_mapping_test.go |
Tests PostgreSQL error translation and cascades. |
test/e2e/db/lister_test.go |
Tests filtering, ordering, and pagination. |
test/e2e/db/schema_test.go |
Validates live PostgreSQL schema behavior. |
test/e2e/db/labels_test.go |
Adds future label-test placeholders. |
test/e2e/db/migrations_test.go |
Adds future migration-test placeholders. |
test/e2e/db/relationships_test.go |
Adds future relationship-test placeholders. |
test/e2e/db/retention_test.go |
Adds future retention-test placeholder. |
Review details
- Files reviewed: 14/14 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+323
to
+327
| for _, r := range resp.Results { | ||
| if r.Summary.Status != pb.RecordSummary_SUCCESS { | ||
| t.Errorf("filter leaked non-SUCCESS result: %s (status=%v)", r.Name, r.Summary.Status) | ||
| } | ||
| successNames = append(successNames, r.Name) |
Comment on lines
+234
to
+237
| err = rawDB.Raw( | ||
| `SELECT count(*) FROM results WHERE annotations @> ?`, | ||
| `{"env":"production"}`, | ||
| ).Scan(&count).Error |
tekton-robot
added
the
needs-rebase
Contributor
|
@adityavshinde: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add Postgres-specific e2e test suite (
test/e2e/db/) that exercises databasebehavior the SQLite-backed unit tests cannot reach:
pgconn.PgErrorSQLSTATEerror mapping,
jsonbcolumn types and operators, CEL -> SQL filter/sort/paginationon real Postgres, FK cascade, and schema correctness.
Tests run against the deployed API server in the kind cluster and its live
Postgres instance via gRPC - not an in-process server or throwaway database.
What's included:
jsonb @>)pageSize≥5, ListRecords)t.Skipfor future stories (labels, migrations, relationships, retention)test/e2e/client/config.go(eliminates duplication betweene2e_test.goanddb_test.go)e2e.sh: port-forward on15432,DB_URLenv var, password suppressed from traces, cleanup on failuretest/e2e/README.mdandtest/e2e/db/README.mdupdated/created/kind feature
Submitter Checklist
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes