Skip to content

fix(cve): remove vulnerable pgproto3/v2 (CVE-2026-32286) - #1446

Open
khrm wants to merge 1 commit into
tektoncd:mainfrom
khrm:fix/remove-pgproto3-v2-cve
Open

fix(cve): remove vulnerable pgproto3/v2 (CVE-2026-32286)#1446
khrm wants to merge 1 commit into
tektoncd:mainfrom
khrm:fix/remove-pgproto3-v2-cve

Conversation

@khrm

@khrm khrm commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Migrate the two remaining usages of github.com/jackc/pgconn (v1) to github.com/jackc/pgx/v5/pgconn, eliminating the transitive dependency on github.com/jackc/pgproto3/v2 which has an unpatched DoS vulnerability (CVE-2026-32286).

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Tested your changes locally (if this is a code change)
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 18, 2026
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 18, 2026

@khrm khrm left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Aug 18, 2026

@khrm khrm left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the vulnerable standalone pgproto3/v2 dependency by standardizing PostgreSQL error handling on pgx/v5/pgconn.

Changes:

  • Migrates remaining pgconn v1 imports to pgx/v5.
  • Removes obsolete dependency metadata and vendored sources.
  • Updates PostgreSQL error translation tests.

Reviewed changes

Copilot reviewed 3 out of 85 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
go.mod Removes obsolete modules.
go.sum Removes obsolete checksums.
tools/postgres-migrate/main.go Uses pgx/v5/pgconn.
pkg/api/server/db/errors/postgres/postgres_test.go Consolidates tests on pgx/v5.
vendor/modules.txt Removes obsolete vendored modules.
vendor/github.com/jackc/pgproto3/v2/* Removes vendored pgproto3/v2 package files.
vendor/github.com/jackc/pgio/* Removes obsolete pgio package files.
vendor/github.com/jackc/pgconn/* Removes obsolete pgconn v1 package files.
vendor/github.com/jackc/pgconn/internal/ctxwatch/context_watcher.go Removes pgconn v1 internal helper.
vendor/github.com/jackc/chunkreader/v2/* Removes obsolete chunkreader package files.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread pkg/api/server/db/errors/postgres/postgres_test.go
Migrate the two remaining usages of github.com/jackc/pgconn (v1) to
github.com/jackc/pgx/v5/pgconn, eliminating the transitive dependency
on github.com/jackc/pgproto3/v2 which has an unpatched DoS
vulnerability (CVE-2026-32286, Dependabot tektoncd#78).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@khrm
khrm force-pushed the fix/remove-pgproto3-v2-cve branch from d10c675 to c64162d Compare August 18, 2026 14:46
@tekton-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divyansh42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2026
@divyansh42

Copy link
Copy Markdown
Member

@khrm can you please change the release notes block to

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. release-note-none Denotes a PR that doesnt merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants