change: add explicit secrets definition for workflow_call - #3481
Merged
Conversation
tekton-robot
added
the
kind/cleanup
tekton-robot
added
the
size/XS
7 tasks
vdemeester
approved these changes
Jul 2, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Contributor
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR explicitly defines the required secrets schema for the reusable
_chatops_retest.ymlworkflow under theon.workflow_call.secretsconfiguration.Why this is needed
Currently, the workflow expects
secrets.CHATOPS_TOKENwithin its jobs but does not declare it as an input in theworkflow_calltrigger. This triggers security/audit validation warnings (such as fromzizmor) regarding unrestricted secret inheritance (secrets: inherit) in calling repositories. Explicitly declaring the secret unblocks precise pass-through mapping from the calling side.Cross-referencing: part of the hardening efforts to unblock tektoncd/dashboard#5071.
/kind cleanup
Submitter Checklist