Skip to content

feat: use prefix instead hard coded admin #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sealday wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

feat: use prefix instead hard coded admin #595

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f5a54f0
feat: use prefix instead hard coded admin
sealday Jun 30, 2025
162a302
chore: add strict mode
sealday Jun 30, 2025
34b15b0
chore: remove unused initial statements
sealday Jul 2, 2025
e08d97b
Merge remote-tracking branch 'origin/main' into feat/new-router-system
sealday Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/client/src/application/Application.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,12 +109,16 @@ export class Application {

get adminUrl() {
if (this.name === 'main') {
return '/admin/';
return `/${this.prefix}/`;
} else {
return `/apps/${this.name}/admin/`;
return `/apps/${this.name}/${this.prefix}/`;
}
}

get prefix() {
return 'dashboard';
}

constructor(protected options: ApplicationOptions = {}) {
this.initRequireJs();
define(this, {
Expand Down
275 changes: 0 additions & 275 deletions packages/client/src/application/CustomRouterContextProvider.tsx
View file
Open in desktop

This file was deleted.

15 changes: 6 additions & 9 deletions packages/client/src/application/RouterManager.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import {
import VariablesProvider from '../variables/VariablesProvider';
import { Application } from './Application';
import { BlankComponent, RouterContextCleaner } from './components';
import { CustomRouterContextProvider } from './CustomRouterContextProvider';

export interface BrowserRouterOptions extends Omit<BrowserRouterProps, 'children'> {
type?: 'browser';
Expand Down Expand Up @@ -146,14 +145,12 @@ export class RouterManager {
const Provider = () => {
const BaseLayout = useContext(BaseLayoutContext);
return (
<CustomRouterContextProvider>
<BaseLayout>
<VariablesProvider>
<Outlet />
{children}
</VariablesProvider>
</BaseLayout>
</CustomRouterContextProvider>
<BaseLayout>
<VariablesProvider>
<Outlet />
{children}
</VariablesProvider>
</BaseLayout>
);
};

Expand Down
Loading