Add spec to ensure @ in embedded code is not converted to Twitter link#33
Draft
Add spec to ensure @ in embedded code is not converted to Twitter link#33
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a test case to verify that @ symbols within embedded HTML code (specifically in iframe URLs) are not incorrectly converted into Twitter links. While recent commits fixed similar issues for YouTube URLs and regular URLs containing @, this test documents that embedded code still has the conversion problem.
- Adds a new describe block testing Mastodon embed code handling
- Documents that
@symbols in iframe src attributes should not be converted to Twitter links - Uses a Mastodon server URL (
https://mathtod.online/@Nyoho/...) as the test case
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
確かに Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
Author
|
現在のtdiaryがbundler 2.6に依存しているのでruby 3.3以前のbundlerではビルドできずにテスト以前に落ちている。 アクションをいじればいいのかな |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
最近のコミットによってYouTubeのURLにある@マークやexample.comなどの普通のURLの途中にある@はTwitterリンクとして変換されなくなっていますが、埋め込みコード内のものは変換されてしまうことに気付きました。
とりあえずテストだけ書きました。