Skip to content

Add spec to ensure @ in embedded code is not converted to Twitter link#33

Draft
Nyoho wants to merge 3 commits intomasterfrom
at-mark-in-embed-code-should-not-be-converted
Draft

Add spec to ensure @ in embedded code is not converted to Twitter link#33
Nyoho wants to merge 3 commits intomasterfrom
at-mark-in-embed-code-should-not-be-converted

Conversation

@Nyoho
Copy link
Copy Markdown
Member

@Nyoho Nyoho commented Oct 21, 2025

最近のコミットによってYouTubeのURLにある@マークやexample.comなどの普通のURLの途中にある@はTwitterリンクとして変換されなくなっていますが、埋め込みコード内のものは変換されてしまうことに気付きました。

とりあえずテストだけ書きました。

@Nyoho Nyoho marked this pull request as draft October 21, 2025 10:17
@Nyoho Nyoho requested a review from Copilot October 21, 2025 10:18
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a test case to verify that @ symbols within embedded HTML code (specifically in iframe URLs) are not incorrectly converted into Twitter links. While recent commits fixed similar issues for YouTube URLs and regular URLs containing @, this test documents that embedded code still has the conversion problem.

  • Adds a new describe block testing Mastodon embed code handling
  • Documents that @ symbols in iframe src attributes should not be converted to Twitter links
  • Uses a Mastodon server URL (https://mathtod.online/@Nyoho/...) as the test case

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread spec/tdiary/style/gfm_spec.rb Outdated
確かに

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Nyoho
Copy link
Copy Markdown
Member Author

Nyoho commented Oct 24, 2025

現在のtdiaryがbundler 2.6に依存しているのでruby 3.3以前のbundlerではビルドできずにテスト以前に落ちている。

アクションをいじればいいのかな

Because the current Bundler version (2.5.22) does not satisfy bundler >= 2.6, <
3.0
  and every version of tdiary depends on bundler >= 2.6, < 3.0,
  tdiary cannot be used.
So, because Gemfile depends on tdiary >= 0,
  version solving has failed.

Your bundle requires a different version of Bundler than the one you're running.
Install the necessary version with `gem install bundler:2.7.2` and rerun bundler
using `bundle _2.7.2_ lock`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants