Skip to content

Export the tap::ambi alias, fetch GTest by git clone, fix the book's site-url #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tap merged 1 commit into from
Jul 28, 2026
Merged

Export the tap::ambi alias, fetch GTest by git clone, fix the book's site-url #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,12 @@ add_subdirectory(submodules/dsptap)

add_library(ambitap INTERFACE)
add_library(AmbiTap::ambitap ALIAS ambitap)
# The family-wide alias, per the namespace convention in taphouse's README: one
# `tap::<library>` sub-namespace per repo, and the CMake alias matches it. The
# older spelling above stays so existing consumers keep working; prefer
# `tap::ambi` in new code. Note this is a build-tree alias only -- the
# installed config package still exports under its own namespace.
add_library(tap::ambi ALIAS ambitap)
target_include_directories(ambitap INTERFACE
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
$<INSTALL_INTERFACE:include>)
Expand Down
7 changes: 6 additions & 1 deletion book/book.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,9 @@ create-missing = false
[output.html]
default-theme = "rust"
git-repository-url = "https://github.com/tap/AmbiTap"
site-url = "/AmbiTap/book/"
# The Pages site is assembled in docs.yml as site/ with this book at the ROOT
# (and the Doxygen API reference under site/api/), so the book is served from
# /AmbiTap/, not /AmbiTap/book/. site-url feeds the absolute links in the
# generated 404.html; pointing it at a path the site does not have gave the
# 404 page a broken "home" link.
site-url = "/AmbiTap/"
14 changes: 11 additions & 3 deletions tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,16 @@
include(FetchContent)
# Fetched by git clone at a commit pin, which is the form every sibling *Tap repo
# uses (DspTap/MuTap/RatioTap/SampleRateTap). This repo previously declared a
# release *tarball* instead; that is the one mechanism an HTTPS-proxied build
# environment blocks, so AmbiTap was the only library in the family whose tests
# could not be configured behind a proxy. Note the family currently runs two
# GTest versions -- this repo on v1.15.2, the other four on v1.14.0. Unifying
# them is a deliberate call for whoever needs it, not a side effect of this
# mechanism change.
FetchContent_Declare(googletest
URL https://github.com/google/googletest/archive/refs/tags/v1.15.2.tar.gz
URL_HASH SHA256=7b42b4d6ed48810c5362c265a17faebe90dc2373c885e5216439d37927f02926
DOWNLOAD_EXTRACT_TIMESTAMP TRUE
GIT_REPOSITORY https://github.com/google/googletest.git
# Commit pin, not the movable tag: tags can be re-pointed upstream.
GIT_TAG b514bdc898e2951020cbdca1304b75f5950d1f59 # v1.15.2
# Prefer an already-installed GTest (offline builds, distro packages).
FIND_PACKAGE_ARGS NAMES GTest
)
Expand Down
Loading