Skip to content

Added <option> disable. #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
perdodi wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added <option> disable. #933

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54a1105
Added <option> disable.
perdodi Oct 3, 2017
22ac81a
Consistent code formatting
perdodi Nov 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion dist/jsgrid.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2173,13 +2173,15 @@

$.each(this.items, function(index, item) {
var value = valueField ? item[valueField] : index,
text = textField ? item[textField] : item;
text = textField ? item[textField] : item,
disabled = item['disabled'];

var $option = $("<option>")
.attr("value", value)
.text(text)
.appendTo($result);

$option.prop("disabled", (disabled === true));
$option.prop("selected", (selectedIndex === index));
});

Expand Down
6 changes: 4 additions & 2 deletions src/fields/jsgrid.field.select.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,13 +100,15 @@

$.each(this.items, function(index, item) {
var value = valueField ? item[valueField] : index,
text = textField ? item[textField] : item;
text = textField ? item[textField] : item,
disabled = item['disabled'];

@tabalinas tabalinas Oct 17, 2017

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we use double-quotes usually, let's be consistent. While I'd rather just use dot notation here:
disabled = (item.disabled === true).


var $option = $("<option>")
.attr("value", value)
.text(text)
.appendTo($result);


$option.prop("disabled", (disabled === true));

@tabalinas tabalinas Oct 17, 2017

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep indentation consistent: 4 spaces.

});

$result.prop("disabled", !!this.readOnly);
Expand Down