feat: use full path in location search#1511
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Summary by CodeRabbit
WalkthroughThe Location Selector component's fuzzy search now searches both location name and tree path fields simultaneously. The fuzzysort configuration is updated from a single-field ChangesLocation Selector Search Enhancement
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Security Recommendations
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What type of PR is this?
What this PR does / why we need it:
This PR is including
treeStringin location search. The reason for that is, that if you have like me locations that are following some pattern, e.g. "Rack 1 > Shelf 1", "Rack 2 > Shelf 1", etc. it's impossible currently to search particular Shelf. Searching "Shelf 1" will return multiple results. Especially on a mobile phone, the usability is low.This PR additionally includes
treeStringin the search, so searches like "Rack 1 > Shelf 1" or "Shelf 1 Rack 1" can be performed. The drawback is that search for "Rack 1" will now also return sub-categories, but I think it's an acceptable drawback, as the "Rack 1" should be shown first anyway (being more specific).Which issue(s) this PR fixes:
I have not created an issue for this.
Testing
I tested it manually, by running searches in a running application.
PS. Sorry I closed this original PR, because I thought it was merged 15cdd6d (but now I can't find it)