-
-
Notifications
You must be signed in to change notification settings - Fork 441
Maintenance plans / Recurring maintenance #1466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vicwiller
wants to merge
3
commits into
sysadminsmedia:main
Choose a base branch
from
vicwiller:maintenance-plan
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| package v1 | ||
|
|
||
| import ( | ||
| "net/http" | ||
|
|
||
| "github.com/google/uuid" | ||
| "github.com/hay-kot/httpkit/errchain" | ||
| "github.com/sysadminsmedia/homebox/backend/internal/core/services" | ||
| "github.com/sysadminsmedia/homebox/backend/internal/data/repo" | ||
| "github.com/sysadminsmedia/homebox/backend/internal/web/adapters" | ||
| ) | ||
|
|
||
| // HandleMaintenancePlanGetAll godoc | ||
| // | ||
| // @Summary Query Maintenance Plans | ||
| // @Tags Item Maintenance | ||
| // @Produce json | ||
| // @Param id path string true "Item ID" | ||
| // @Success 200 {array} repo.MaintenancePlan | ||
| // @Router /v1/entities/{id}/maintenance/plans [GET] | ||
| // @Security Bearer | ||
| func (ctrl *V1Controller) HandleMaintenancePlanGetAll() errchain.HandlerFunc { | ||
| fn := func(r *http.Request, itemID uuid.UUID, _ struct{}) ([]repo.MaintenancePlan, error) { | ||
| auth := services.NewContext(r.Context()) | ||
| return ctrl.repo.MaintEntry.ListPlansByItemID(auth, auth.GID, itemID) | ||
| } | ||
|
|
||
| return adapters.QueryID("id", fn, http.StatusOK) | ||
| } | ||
|
|
||
| // HandleMaintenancePlanCreate godoc | ||
| // | ||
| // @Summary Create Maintenance Plan | ||
| // @Tags Item Maintenance | ||
| // @Produce json | ||
| // @Param id path string true "Item ID" | ||
| // @Param payload body repo.MaintenancePlanCreate true "Plan Data" | ||
| // @Success 201 {object} repo.MaintenancePlan | ||
| // @Router /v1/entities/{id}/maintenance/plans [POST] | ||
| // @Security Bearer | ||
| func (ctrl *V1Controller) HandleMaintenancePlanCreate() errchain.HandlerFunc { | ||
| fn := func(r *http.Request, itemID uuid.UUID, body repo.MaintenancePlanCreate) (repo.MaintenancePlan, error) { | ||
| auth := services.NewContext(r.Context()) | ||
| return ctrl.repo.MaintEntry.CreatePlan(auth, itemID, body) | ||
| } | ||
|
|
||
| return adapters.ActionID("id", fn, http.StatusCreated) | ||
| } | ||
|
|
||
| // HandleMaintenancePlanUpdate godoc | ||
| // | ||
| // @Summary Update Maintenance Plan | ||
| // @Tags Maintenance | ||
| // @Produce json | ||
| // @Param id path string true "Plan ID" | ||
| // @Param payload body repo.MaintenancePlanUpdate true "Plan Data" | ||
| // @Success 200 {object} repo.MaintenancePlan | ||
| // @Router /v1/maintenance/plans/{id} [PUT] | ||
| // @Security Bearer | ||
| func (ctrl *V1Controller) HandleMaintenancePlanUpdate() errchain.HandlerFunc { | ||
| fn := func(r *http.Request, planID uuid.UUID, body repo.MaintenancePlanUpdate) (repo.MaintenancePlan, error) { | ||
| auth := services.NewContext(r.Context()) | ||
| return ctrl.repo.MaintEntry.UpdatePlan(auth, planID, body) | ||
| } | ||
|
|
||
| return adapters.ActionID("id", fn, http.StatusOK) | ||
| } | ||
|
|
||
| // HandleMaintenancePlanDelete godoc | ||
| // | ||
| // @Summary Delete Maintenance Plan | ||
| // @Tags Maintenance | ||
| // @Produce json | ||
| // @Param id path string true "Plan ID" | ||
| // @Success 204 | ||
| // @Router /v1/maintenance/plans/{id} [DELETE] | ||
| // @Security Bearer | ||
| func (ctrl *V1Controller) HandleMaintenancePlanDelete() errchain.HandlerFunc { | ||
| fn := func(r *http.Request, planID uuid.UUID) (any, error) { | ||
| auth := services.NewContext(r.Context()) | ||
| return nil, ctrl.repo.MaintEntry.DeletePlan(auth, planID) | ||
| } | ||
|
|
||
| return adapters.CommandID("id", fn, http.StatusNoContent) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: sysadminsmedia/homebox
Length of output: 13038
🏁 Script executed:
Repository: sysadminsmedia/homebox
Length of output: 4032
🏁 Script executed:
Repository: sysadminsmedia/homebox
Length of output: 4020
🏁 Script executed:
Repository: sysadminsmedia/homebox
Length of output: 70
🏁 Script executed:
Repository: sysadminsmedia/homebox
Length of output: 1551
Call
body.Validate()in both handlers before passing to repository methods.MaintenancePlanCreate.Validate()andMaintenancePlanUpdate.Validate()enforce critical constraints (IntervalValue >= 1, knownIntervalUnit), but neither handler invokes them. Invalid input bypasses these checks and flows directly into the repository layer, where only Ent's enum validation provides defense at best. A client posting{"intervalValue":0}will not be caught.Affected handlers and fix
HandleMaintenancePlanCreate (lines 42–47):
fn := func(r *http.Request, itemID uuid.UUID, body repo.MaintenancePlanCreate) (repo.MaintenancePlan, error) { + if err := body.Validate(); err != nil { + return repo.MaintenancePlan{}, validate.NewRequestError(err, http.StatusBadRequest) + } auth := services.NewContext(r.Context()) return ctrl.repo.MaintEntry.CreatePlan(auth, itemID, body) }HandleMaintenancePlanUpdate (lines 61–66): Apply the same pattern.
🤖 Prompt for AI Agents