Skip to content

Make plugin view selectable in Code Plugins - #525

Open
dnicolson wants to merge 1 commit into
swiftbar:mainfrom
dnicolson:patch-1
Open

Make plugin view selectable in Code Plugins#525
dnicolson wants to merge 1 commit into
swiftbar:mainfrom
dnicolson:patch-1

Conversation

@dnicolson

Copy link
Copy Markdown
Contributor

No description provided.

@melonamin

Copy link
Copy Markdown
Member

Low: SwiftBar/UI/Preferences/PluginsPreferencesView.swift:79-82 applies .contentShape(Rectangle()) before the outer .padding(5), so the padded edge remains outside the parent tap region. In a real app test, ordinary trailing whitespace selected the row, but clicking inside the visible trailing padded strip did not change selection.

Move the padding before the expanding frame/content shape, or attach the tap gesture to a full-width outer row container. A UI test should click the painted trailing edge.

The nested enable toggle behaved correctly: toggling it did not also select the row. The current GitHub synthetic merge passed all 206 tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants