Skip to content
This repository was archived by the owner on Feb 15, 2023. It is now read-only.

Version bump for Dev Dependencies #202

Open
awhitford wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Version bump for Dev Dependencies #202

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c8e50b6
Bumped devDependencies to latest major versions.
awhitford Dec 28, 2020
fa818bc
Bumped devDependencies to latest major versions.
awhitford Dec 28, 2020
22422da
Reverting unintentional indentation change.
awhitford Jan 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@
"start": "sirv public"
},
"devDependencies": {
"@rollup/plugin-commonjs": "^16.0.0",
"@rollup/plugin-node-resolve": "^10.0.0",
"rollup": "^2.3.4",
"@rollup/plugin-commonjs": "^17.0.0",
"@rollup/plugin-node-resolve": "^11.0.0",
"rollup": "^2.35.1",

@benmccann benmccann Jan 18, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's no need to change this. ^2.3.4 will get you the latest 2.x version

"rollup-plugin-css-only": "^3.1.0",
"rollup-plugin-livereload": "^2.0.0",
"rollup-plugin-svelte": "^7.0.0",
Expand Down
8 changes: 4 additions & 4 deletions scripts/setupTypeScript.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
/** This script modifies the project to support TS code in .svelte files like:

<script lang="ts">
export let name: string;
export let name: string;

@antony antony Jan 6, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The style guide for Svelte is to use tabs, not spaces.

@awhitford awhitford Jan 7, 2021 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind reverting this -- this is just Format on Save. However, where is that Svelte Style Guide documented? (I couldn't find anything.) And would that apply to this js script (since it isn't a .svelte file)? And it is commented out, so this is actually just a comment.

</script>

As well as validating the code for CI.
Expand All @@ -24,8 +24,8 @@ const packageJSON = JSON.parse(fs.readFileSync(path.join(projectRoot, "package.j
packageJSON.devDependencies = Object.assign(packageJSON.devDependencies, {
"svelte-check": "^1.0.0",
"svelte-preprocess": "^4.0.0",
"@rollup/plugin-typescript": "^6.0.0",
"typescript": "^3.9.3",
"@rollup/plugin-typescript": "^8.0.0",
"typescript": "^4.0.0",
"tslib": "^2.0.0",
"@tsconfig/svelte": "^1.0.0"
})
Expand Down Expand Up @@ -82,7 +82,7 @@ const tsconfig = `{
"include": ["src/**/*"],
"exclude": ["node_modules/*", "__sapper__/*", "public/*"]
}`
const tsconfigPath = path.join(projectRoot, "tsconfig.json")
const tsconfigPath = path.join(projectRoot, "tsconfig.json")
fs.writeFileSync(tsconfigPath, tsconfig)

// Delete this script, but not during testing
Expand Down