Skip to content

db: Don't checksum on every read #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
saleemrashid wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

db: Don't checksum on every read #448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4db37ce
db: Don't checksum on every read
saleemrashid Apr 6, 2026
e15072e
fuse: Performance tweaks
saleemrashid Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions db.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1050,16 +1050,7 @@ func (db *DB) SyncDatabase(ctx context.Context) (err error) {
// ReadDatabaseAt reads from the database at the specified index.
func (db *DB) ReadDatabaseAt(ctx context.Context, f *os.File, data []byte, offset int64, owner uint64) (int, error) {
n, err := f.ReadAt(data, offset)

// Compute checksum if page aligned.
var chksum string
var pgno uint32
if db.pageSize != 0 && offset%int64(db.pageSize) == 0 && len(data) == int(db.pageSize) {
pgno = uint32(offset/int64(db.pageSize)) + 1
chksum = ltx.ChecksumPage(pgno, data).String()
}
TraceLog.Printf("[ReadDatabaseAt(%s)]: offset=%d size=%d pgno=%d chksum=%s owner=%d %s", db.name, offset, len(data), pgno, chksum, owner, errorKeyValue(err))

TraceLog.Printf("[ReadDatabaseAt(%s)]: offset=%d size=%d owner=%d %s", db.name, offset, len(data), owner, errorKeyValue(err))
return n, err
}

Expand Down
3 changes: 3 additions & 0 deletions fuse/file_system.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,9 @@ func (fsys *FileSystem) Mount(skipUnmount bool) (err error) {
fuse.FSName("litefs"),
fuse.LockingPOSIX(),
fuse.ExplicitInvalidateData(),
fuse.AsyncRead(),
fuse.MaxBackground(128),
fuse.MaxReadahead(1 << 20),
}
if fsys.AllowOther {
options = append(options, fuse.AllowOther())
Expand Down
Loading