Repository navigation
group by ordinal: Fix bug on aliased columns - #7435
Merged
Merged
Conversation
mattnibs
force-pushed
the
group-by-ordinal-alias
branch
from
October 8, 2026 22:44
b387046 to
ab1f192
Compare
This commit fixes an issue when using group by ordinal on aliased columns that would produce an incorrect expression that could be matched with the original from clause expression. Fix by resolving the expression using the column alias rather the original expression. Fixes #7357
mattnibs
force-pushed
the
group-by-ordinal-alias
branch
from
October 8, 2026 22:44
ab1f192 to
959da2c
Compare
nwt
approved these changes
Oct 8, 2026
nwt
left a comment
nwt
left a comment
Collaborator
There was a problem hiding this comment.
People are saying this is how it's done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue when using group by ordinal on aliased columns that would produce an incorrect expression that could be matched with the original from clause expression. Fix by resolving the expression using the column alias rather the original expression.
Fixes #7357