Repository navigation
remove support for old BSUP format - #7434
Merged
Merged
Conversation
nwt
approved these changes
Oct 8, 2026
Comment on lines
+180
to
+181
| reader, err := bsupio.NewReader(t.Context(), super.NewContext(), &buffer, nil, 1) | ||
| recActual, err := sbuf.PullerReader(sbuf.NewMaterializer(reader)).Read() |
Collaborator
There was a problem hiding this comment.
Nits: Use bsupio.NewValueReader. And check errors.
Suggested change
| reader, err := bsupio.NewReader(t.Context(), super.NewContext(), &buffer, nil, 1) | |
| recActual, err := sbuf.PullerReader(sbuf.NewMaterializer(reader)).Read() | |
| reader, err := bsupio.NewValueReader(t.Context(), super.NewContext(), &buffer) | |
| require.NoError(t, err) | |
| recActual, err := reader.Read() | |
| require.NoError(t, err) |
Comment on lines
+247
to
+249
| reader, err := bsupio.NewReader(t.Context(), super.NewContext(), &buffer, nil, 1) | ||
| require.NoError(t, err) | ||
| recActual, err := sbuf.PullerReader(sbuf.NewMaterializer(reader)).Read() |
Collaborator
There was a problem hiding this comment.
Nit:
Suggested change
| reader, err := bsupio.NewReader(t.Context(), super.NewContext(), &buffer, nil, 1) | |
| require.NoError(t, err) | |
| recActual, err := sbuf.PullerReader(sbuf.NewMaterializer(reader)).Read() | |
| reader, err := bsupio.NewValueReader(t.Context(), super.NewContext(), &buffer) | |
| require.NoError(t, err) | |
| recActual, err := reader.Read() |
| var out Output | ||
| rawSrc := oldbsup.NewReader(super.NewContext(), &rawBSUP) | ||
| defer rawSrc.Close() | ||
| rawSrc, err := bsupio.NewReader(t.Context(), super.NewContext(), &rawBSUP, nil, 1) |
Collaborator
There was a problem hiding this comment.
Nit:
Suggested change
| rawSrc, err := bsupio.NewReader(t.Context(), super.NewContext(), &rawBSUP, nil, 1) | |
| rawSrc, err := bsupio.NewValueReader(t.Context(), super.NewContext(), &rawBSUP) |
| bytesReader := bytes.NewReader(bs) | ||
| reader := oldbsup.NewReader(sctx, bytesReader) | ||
| defer reader.Close() | ||
| reader, err := bsupio.NewReader(ctx, sctx, bytesReader, nil, 1) |
Collaborator
There was a problem hiding this comment.
Nit:
Suggested change
| reader, err := bsupio.NewReader(ctx, sctx, bytesReader, nil, 1) | |
| reader, err := bsupio.NewValueReader(ctx, sctx, bytesReader) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.