Repository navigation
add fast path to database ingest - #7429
Merged
Merged
Conversation
This commit replaces the storage format of the databsae with BSUP columns. We're currently suboptimally writing one big column frame per storage object but this will change in a subsequent PR when we add a row-group-like construct (pruner and vcache just need to understand this). We put merge and the pool scanners in subdirectories of runtime/op to break import loops. We need to revisit interfaces again to come up with a cleaner design but this will come later. The ingest path is now native columns though there is an scode boomerang to sort the input. We'll avoid this and add optional sort keys in a subsequent PR.
This commit adds a fast path for sorting ingest regarding the common case that a table sort key is a simple primary type. In this case, we do native sorts on the vector data to compute an index which is used to create a view. I believe the changes to the tests has to do with variation in stability of the sort between sam and this new path. Sam sort will go away soon so I'm not concerned about maintaining the invariant between the two.
nwt
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a fast path for sorting ingest regarding the common case that a table sort key is a simple primary type. In this case, we do native sorts on the vector data to compute an index which is used to create a view.
I believe the changes to the tests has to do with variation in stability of the sort between sam and this new path. Sam sort will go away soon so I'm not concerned about maintaining the invariant between the two.