fix: block broken button digits typed via keyboard#13
Open
Bindkushal wants to merge 1 commit intosugarlabs:mainfrom
Open
fix: block broken button digits typed via keyboard#13Bindkushal wants to merge 1 commit intosugarlabs:mainfrom
Bindkushal wants to merge 1 commit intosugarlabs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Even though broken buttons were visually disabled and unclickable, a player could still type broken digits directly via keyboard into the equation display, bypassing the core game mechanic.
Fix
In _on_entry_changed() in activity.py, added real-time keyboard input filtering — if a broken digit is typed, it is silently removed from the display immediately, keeping the game mechanic consistent whether using mouse or keyboard.